Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] account_reversal_usability #1761

Open
sbidoul opened this issue Nov 3, 2023 · 1 comment
Open

[ADD] account_reversal_usability #1761

sbidoul opened this issue Nov 3, 2023 · 1 comment
Labels
enhancement stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@sbidoul
Copy link
Member

sbidoul commented Nov 3, 2023 •
edited
Loading

I propose the creation of a module that improves the usability of account move reversal:

  • add a to_be_reversed flag on account.move (we had that in the past in the account_reversal OCA module)
  • this flag is set to False when a reversal is done (best way to do it to be investigated, it could be on write of the reversed_entry_id field of the reversing entry)
  • add a "To Be Reversed" search filter (we had that in the past in the account_reversal OCA module)
  • show the reversal_move_id field in the view as Reversal Entry (it is a o2m, but in practice it is a one2one, and the computed m2o to be displayed could be called reversal_id for compatibility with the old OCA module)

We could then improve some OCA modules that generate entries to be reversed to set this flag (for instance, in OCA/account-closing).
@sbidoul sbidoul transferred this issue from OCA/account-analytic Nov 3, 2023
This was referenced Nov 6, 2023
Closed
Open
IT-Ideas pushed a commit to acsone/account-financial-tools that referenced this issue Nov 14, 2023
[IMP] account_reversal: add reversal_id field
668e9a4 
This commit adds the `reversal_id` field in order to improve
the UX of the move reversal functionality. The field has been
added to the form view close to the `reversed_entry_id` field
already present in the view.

This commit also introduces a constraint preventing the user
to flag a move as to be reversed when a non cancelled reversal
move has already been created. This allows simplifying the domain
used on the `to_be_reversed` filter.

Finally, it also convert the deprecated `SavepointCase` test
into a `TransactionCase` one.

Fixes: OCA#1761
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2024

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ADD] account_reversal_usability acsone/account-financial-tools
1 participant
@sbidoul