Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ontology description page shows wrong URL when using custom (non-OBO) ontologies #88

Open
ashkotin opened this issue Mar 27, 2023 · 15 comments
Labels
bug Something isn't working

Comments

@ashkotin
Copy link

on the page https://monarch-initiative.github.io/monarch-ontology-dashboard/dashboard/chr/dashboard.html the URL for chr in "Dashboard Report - chr" raises 404.

@matentzn matentzn changed the title 404 for chr ontology description page Ontology description page shows wrong URL when using custom (non-OBO) ontologies Mar 27, 2023
@matentzn
Copy link
Contributor

Thank you for the feedback.

@anitacaron (not now, obviously) I think this should be fixed by redirecting the URL from the ontology description page to mirror_from if it exists, but we should make sure that this does not break the normal "OBO" dashboard.

@ashkotin
Copy link
Author

@anitacaron
Copy link
Collaborator

Maybe this should be the ontology's homepage, if available?

@matentzn
Copy link
Contributor

@ashkotin yes these PURLs are misleading as CHR is not in OBO (yet). Here you can find the ontology https://github.com/monarch-initiative/monochrom, you can ask your questions on the issue tracker there

@matentzn
Copy link
Contributor

@anitacaron For the OBO Dashboard, I would suggest that the link to the OBO Foundry page of the ontology is more appropriate, or at least, that it is somewhere accessible on the ontology description page (if it exists). However, if this becomes to complex, I think your suggestion is an ok enough compromise.

@ashkotin
Copy link
Author

ashkotin commented Mar 28, 2023 via email

@anitacaron
Copy link
Collaborator

anitacaron commented Mar 28, 2023

@matentzn My comment was related to the case of it's not an OBO Foundry ontology.

@matentzn
Copy link
Contributor

Then yes, I agree!

@anitacaron
Copy link
Collaborator

But is there a straightforward way to know that ontology is not part of OBO?

@matentzn
Copy link
Contributor

I think the best hack is to check if the mirror_from field is an obo purl. Maybe there are other pieces of metadata that could be used to determine but not sure

@ashkotin
Copy link
Author

ashkotin commented Mar 28, 2023 via email

@matentzn
Copy link
Contributor

No all people using the dashboard want to have their ontologies on OBO!

@ashkotin
Copy link
Author

ashkotin commented Mar 28, 2023 via email

@matentzn
Copy link
Contributor

Yes, but the process to get that page is extremely complex! Lots of paperwork, not everyone will want that!

@ashkotin
Copy link
Author

ashkotin commented Mar 28, 2023 via email

@anitacaron anitacaron added the bug Something isn't working label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants