Add back filling background with air

Author: Aeltumn

interfaces/src/main/kotlin/com/noxcrew/interfaces/pane/CompletedPane.kt

@@ -1,10 +1,13 @@
 package com.noxcrew.interfaces.pane
 
+import com.noxcrew.interfaces.click.ClickHandler
 import com.noxcrew.interfaces.element.CompletedElement
 import com.noxcrew.interfaces.element.complete
 import com.noxcrew.interfaces.grid.GridMap
 import com.noxcrew.interfaces.grid.GridPoint
 import com.noxcrew.interfaces.grid.HashGridMap
+import com.noxcrew.interfaces.utilities.forEachInGrid
+import com.noxcrew.interfaces.view.AbstractInterfaceView.Companion.COLUMNS_IN_CHEST
 import org.bukkit.entity.Player
 
 /** A grid map of completed elements. */
@@ -34,6 +37,18 @@ internal suspend fun Pane.complete(player: Player): CompletedPane {
     return pane
 }
 
+/** Fills up a completed pane with empty elements. */
+internal fun Pane.convertToEmptyCompletedPaneAndFill(rows: Int): CompletedPane {
+    val pane = convertToEmptyCompletedPane()
+    val airElement = CompletedElement(null, ClickHandler.EMPTY)
+
+    forEachInGrid(rows, COLUMNS_IN_CHEST) { row, column ->
+        pane[row, column] = airElement
+    }
+
+    return pane
+}
+
 /** Converts this pane to either a [CompletedPane] or [CompletedOrderedPane] based on its type. */
 internal fun Pane.convertToEmptyCompletedPane(): CompletedPane {
     if (this is OrderedPane) {

interfaces/src/main/kotlin/com/noxcrew/interfaces/utilities/CollapsablePaneMap.kt

@@ -3,6 +3,7 @@ package com.noxcrew.interfaces.utilities
 import com.noxcrew.interfaces.pane.CompletedPane
 import com.noxcrew.interfaces.pane.Pane
 import com.noxcrew.interfaces.pane.convertToEmptyCompletedPane
+import com.noxcrew.interfaces.pane.convertToEmptyCompletedPaneAndFill
 
 /** A collection of completed panes that can be collapsed to create a new merged [CompletedPane]. */
 internal class CollapsablePaneMap private constructor(
@@ -29,12 +30,12 @@ internal class CollapsablePaneMap private constructor(
         return internal.put(key, value)
     }
 
-    internal fun collapse(): CompletedPane {
+    internal fun collapse(rows: Int, fill: Boolean): CompletedPane {
         cachedPane?.let { pane ->
             return pane
         }
 
-        val pane = basePane.convertToEmptyCompletedPane()
+        val pane = if (fill) basePane.convertToEmptyCompletedPaneAndFill(rows) else basePane.convertToEmptyCompletedPane()
         val current = internal.toMap().values
 
         current.forEach { layer ->

interfaces/src/main/kotlin/com/noxcrew/interfaces/view/AbstractInterfaceView.kt

@@ -201,7 +201,7 @@ public abstract class AbstractInterfaceView<I : InterfacesInventory, T : Interfa
         semaphore.acquire()
         try {
             withTimeout(6.seconds) {
-                pane = panes.collapse()
+                pane = panes.collapse(backing.totalRows(), builder.fillMenuWithAir)
                 renderToInventory { createdNewInventory ->
                     // send an update packet if necessary
                     if (!createdNewInventory && requiresPlayerUpdate()) {