Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config overrides should be based on merging the user config, not the resolved #6179

Closed
schaable opened this issue Jan 23, 2025 · 0 comments · Fixed by #6490
Closed

Config overrides should be based on merging the user config, not the resolved #6179

schaable opened this issue Jan 23, 2025 · 0 comments · Fixed by #6490
Assignees
@ChristopherDedominici
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Milestone
Public Alpha Feat...

Comments

@schaable
Copy link
Member

The current behavior: config overrides are resolved first and then merged into the network config. This approach can be hard to reason about, potentially confusing for users, and can lead to issues when resolving fields that depend on one another.

Proposed solution: store the user config in the HRE (similar to v2), merge the overrides into the user config, and then re-resolve it. This simplifies the code and also ensures proper resolution of interdependent fields.
@schaable schaable added the v-next A Hardhat v3 development task label Jan 23, 2025
@schaable schaable added this to the Public Alpha Feature Rollout milestone Jan 23, 2025
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 23, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Jan 23, 2025
@kanej kanej moved this from Backlog to To-do in Hardhat Mar 18, 2025
@ChristopherDedominici ChristopherDedominici self-assigned this Mar 18, 2025
@kanej kanej moved this from To-do to In Progress in Hardhat Mar 18, 2025
@ChristopherDedominici ChristopherDedominici moved this from In Progress to In Review in Hardhat Mar 24, 2025
@kanej kanej linked a pull request Mar 24, 2025 that will close this issue
[Investigation] Config overrides should be based on merging the user config, not the resolved #6490
Merged
@github-project-automation github-project-automation bot moved this from In Review to Done in Hardhat Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristopherDedominici ChristopherDedominici

Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Status: Done
Milestone
Public Alpha Feature Rollout
2 participants
@schaable @ChristopherDedominici