Skip to content

Commit 80503e9

Browse files
author
Nodar Tchumbadze
committed
comments for future refactoring
1 parent a33a7ea commit 80503e9

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed
-24 Bytes
Binary file not shown.

src/com/nodrex/datamatrix/DataMatrix.java

+5-7
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@ protected IDataMatrix<Data> clone() throws CloneNotSupportedException {
6363
* Removes id of this matrix form ids list.
6464
*/
6565
protected void finalize() throws Throwable {
66-
if (this.id.equals(""))
67-
return;
66+
if (this.id.equals("")) return;
6867
DataMatrix.ids.remove(this.id);
6968
}
7069

@@ -117,12 +116,9 @@ public String toString() {
117116
*
118117
* @return true if both matrixes have same dimension and same data,
119118
* otherwise returns false.
120-
* @throws NullPointerException
121-
* if given parameter is null.
122119
*/
123-
public boolean equals(Object obj) throws NullPointerException {
124-
if (obj == null)
125-
throw new NullPointerException();
120+
public boolean equals(Object obj) {
121+
if (obj == null) return false;
126122
if (obj instanceof DataMatrix) {
127123
try {
128124
@SuppressWarnings("unchecked")
@@ -726,6 +722,7 @@ public String getId() {
726722
return new String(this.id);
727723
}
728724

725+
//getData_s magivrad sxva rame unda gavaketo , romelic monacemebs daakopirebs. aman imena am obietis data unda daabrunos.
729726
public Object[][] getData() {
730727
//correct will be return this.data and other code should be commented
731728
Object[][] newData = new Object[this.linedimension][this.columndimension];
@@ -744,6 +741,7 @@ public void setData(Data[]... data) throws NullPointerException {
744741
for (int i = 0; i < data.length; i++) {
745742
lengthList.add(data[i].length);
746743
}
744+
//TODO imis magivrad , rom mere maxi davutvalo pirvelive iteraciashive unda davitvalo maxi. am shemtxevashi listis shemnac ar iqneba sachiro
747745
init(data.length, Collections.max(lengthList));
748746
//i think here should be this.data = data;
749747
//this.fill(data) should be commented.

0 commit comments

Comments
 (0)