GraphQL sizeInBytes field for mod file fragments sometimes doesn't contain a value

[RedRanger14]

Bug Report

Summary

Some mods are showing incorrect file sizes for the mods. They are showing as 0 Bytes

Steps to reproduce

1. Add the collection "Stardew Valley Artisan Valley Expand"
2. View the file sizes on the mods

Some are showing as 0 e.g. Animated Food and Drinks

What is the expected behaviour?

File sizes should match what they are on the website

Other information

Log files can be found in these locations:

nexusmods.app.main.current.log
nexusmods.app.slim.current.log

• Windows: %LOCALAPPDATA%\NexusMods.App\Logs
• Linux: ~/.local/state/NexusMods.App/Logs

Please attach both nexusmods.app.main and nexusmods.app.slim log files with the most recent dates.

[erri120]

The Nexus Mods API actually sends us this value. You can see the issue also appears on the site itself:

[erri120]

I think this was raised before, not sure if we already have an issue for this, but this an issue with the GraphQL API. We're requesting the mod file details, including sizeInBytes when querying for collection revision info:

NexusMods.App/src/Networking/NexusMods.Networking.NexusWebApi/GraphQL/CollectionRevisionInfo.graphql

Line 23 in d28d6fa

...ModFileFragment

For some reason we don't get back a value and just save 0:

NexusMods.App/src/Networking/NexusMods.Networking.NexusWebApi/Extensions/FragmentExtensions.cs

Lines 54 to 62 in a28e77d

	if (ulong.TryParse(modFileFragment.SizeInBytes, out var size))
	{
	nexusFileResolver.Add(NexusModsFileMetadata.Size, Size.From(size));
	}
	else
	{
	Debug.WriteLine($"Unable to parse `{modFileFragment.SizeInBytes}` as bytes for Uid `{modFileFragment.Uid}`");
	nexusFileResolver.Add(NexusModsFileMetadata.Size, Size.Zero);
	}

See issue #644 on the API repo.

[Pickysaurus]

We might be able to fall back to size * 1000 as that always seems to populate.