Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod update check is inaccurate #2678

Open
Al12rs opened this issue Feb 19, 2025 · 2 comments
Open

Mod update check is inaccurate #2678

Al12rs opened this issue Feb 19, 2025 · 2 comments
Assignees

Comments

@Al12rs
Copy link
Contributor

Al12rs commented Feb 19, 2025

Bug Report

Summary

Our current mod update check is very approximate and can result in inaccurate update data and unexpected behaviour.

Steps to reproduce

SMAPI:

  • Download SMAPI 3.18.2
  • Press update button
  • 4.0.8 will be installed rather than 4.1.10 or grater

SpaceCore (https://www.nexusmods.com/stardewvalley/mods/1348?tab=files):

  • Download 1.2- SpaceCore - 1.0.1
  • No updates are detected instead of getting the latest one
  • Download 1.16.1
  • Press download update
  • 1.27.0 is downloaded correctly
  • but download update button is still available
  • pressing button again downloads 1.23.1?
@Al12rs Al12rs changed the title Mod update check doesn't return the latest version Mod update check is inaccurate Feb 19, 2025
@Sewer56 Sewer56 self-assigned this Feb 19, 2025
@Sewer56 Sewer56 added the Bug label Feb 19, 2025
@Al12rs Al12rs added this to MVP Feb 19, 2025
@Sewer56 Sewer56 moved this to In Progress in MVP Feb 19, 2025
@Sewer56
Copy link
Member

Sewer56 commented Feb 19, 2025

This was a case I tested in development.

Chances are, something changed when main branch got merged not too long before merging into main. Probably something very trivial, I'll bisect and get it sorted when am feeling a bit better in my head.

Would also be a good idea to write tests around this, given the opportunity.

@LukeNexusMods LukeNexusMods added this to the SDV Beta Release milestone Feb 19, 2025
@Sewer56
Copy link
Member

Sewer56 commented Feb 24, 2025

Sorting this right now.
Wow, I can repro, how weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

4 participants