You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just went through your lib and src folders and read your scripts. It looks like you don't check for the result of parseInputfor the currentPage and the perPage variables. This will then make the library not work properly and could cause issues.
I know that the people using your package could simply check the values before they submit them to your library however I feel like it still needs to make its own place into here.
Steps to reproduce
Step 1
Create a JS file (let's call it index.js) and copy-paste the following code :
Intro
Hey there!
I just went through your lib and src folders and read your scripts. It looks like you don't check for the result of
parseInput
for the currentPage and the perPage variables. This will then make the library not work properly and could cause issues.I know that the people using your package could simply check the values before they submit them to your library however I feel like it still needs to make its own place into here.
Steps to reproduce
Step 1
Create a JS file (let's call it index.js) and copy-paste the following code :
or
Step 2
Type
node index.js
and observe the resultResults
Expected
Uncaught TypeError: page is not a number
or
Uncaught TypeError: numItems is not a number
Received
or
The text was updated successfully, but these errors were encountered: