Revert custom sharding WAR #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this just a reminder like #477? |
Yes |
ashors1
force-pushed
the
revert-custom-sharding-war
branch
from
2df268a to
59d8c0a
Compare
|
The WAR is not needed anymore since a proper fix landed: openxla/xla#8896 |
|
Workaround should no longer be needed following openxla/xla#8896. @jaro-sevcik checked this morning. |
olupton
approved these changes
Feb 6, 2024
nouiz
reviewed
Feb 6, 2024
| @@ -133,10 +133,6 @@ while [ : ]; do | |||
| XLA_ARM64_PATCH_LIST=$2 | |||
| shift 2 | |||
| ;; | |||
| --other-xla-patches) | |||
There was a problem hiding this comment.
Keeping that attribute could be useful in the future.
We can always add it back later, but having it for dev could be useful.
hmonishN
pushed a commit
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.