Skip to content

Commit be5b1cb

Browse files
committed
Improve TE test reporting, increase timeout
1 parent 032e978 commit be5b1cb

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.github/workflows/_ci.yaml

+3-2
Original file line numberDiff line numberDiff line change
@@ -528,13 +528,14 @@ jobs:
528528
STATISTICS_SCRIPT: |
529529
summary_line=$(tail -n1 test-te.log)
530530
errors=$(echo $summary_line | grep -oE '[0-9]+ error' | awk '{print $1} END { if (!NR) print 0}')
531-
passed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "CollectReport" and .outcome == "passed") | .outcome' | wc -l)
532-
failed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "CollectReport" and .outcome == "failed") | .outcome' | wc -l)
531+
passed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "TestReport" and .outcome == "passed") | .outcome' | wc -l)
532+
failed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "TestReport" and .outcome == "failed") | .outcome' | wc -l)
533533
total_tests=$((failed_tests + passed_tests))
534534
echo "TOTAL_TESTS=${total_tests}" >> $GITHUB_OUTPUT
535535
echo "ERRORS=${errors}" >> $GITHUB_OUTPUT
536536
echo "PASSED_TESTS=${passed_tests}" >> $GITHUB_OUTPUT
537537
echo "FAILED_TESTS=${failed_tests}" >> $GITHUB_OUTPUT
538+
TIMEOUT_MINUTES: 120
538539
ARTIFACTS: |
539540
test-te.log
540541
pytest-report.jsonl

.github/workflows/_test_unit.yaml

+6-1
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,18 @@ on:
1919
type: string
2020
description: 'Test artifacts to collect'
2121
required: false
22+
TIMEOUT_MINUTES:
23+
type: number
24+
description: 'Maximum test runtime, in minutes'
25+
default: "60"
2226

2327
jobs:
2428
runner:
2529
uses: ./.github/workflows/_runner_ondemand_slurm.yaml
2630
with:
2731
NAME: "A100"
2832
LABELS: "A100,${{ github.run_id }}"
29-
TIME: "01:00:00"
33+
TIME: "${{ inputs.TIMEOUT_MINUTES }}:00"
3034
secrets: inherit
3135

3236
run-unit-test:
@@ -67,6 +71,7 @@ jobs:
6771
- name: Run tests
6872
shell: bash -x -e {0}
6973
continue-on-error: true
74+
timeout-minutes: ${{ inputs.TIMEOUT_MINUTES }}
7075
run: |
7176
${{ inputs.EXECUTE }}
7277

0 commit comments

Comments
 (0)