Skip to content

Commit bcf34bf

Browse files
committed
3.8 minimum
1 parent 62dccd1 commit bcf34bf

File tree

3 files changed

+9
-14
lines changed

3 files changed

+9
-14
lines changed

.github/triage/jax_toolbox_triage/logic.py

+5-7
Original file line numberDiff line numberDiff line change
@@ -164,19 +164,17 @@ def container_search(
164164
return range_start, range_end
165165

166166

167-
if typing.TYPE_CHECKING:
168-
169-
class BuildAndTest(typing.Protocol):
170-
def __call__(
171-
self, *, jax_commit: str, xla_commit: str
172-
) -> typing.Tuple[bool, str, str]: ...
167+
class BuildAndTest(typing.Protocol):
168+
def __call__(
169+
self, *, jax_commit: str, xla_commit: str
170+
) -> typing.Tuple[bool, str, str]: ...
173171

174172

175173
def commit_search(
176174
*,
177175
jax_commits: typing.Sequence[typing.Tuple[str, datetime.datetime]],
178176
xla_commits: typing.Sequence[typing.Tuple[str, datetime.datetime]],
179-
build_and_test: "BuildAndTest",
177+
build_and_test: BuildAndTest,
180178
logger: logging.Logger,
181179
skip_precondition_checks: bool,
182180
):

.github/triage/pyproject.toml

+2-3
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22
name = "jax-toolbox-triage"
33
dynamic = ["version"]
44
# Because this script needs to run on compute clusters *outside* the containers that it
5-
# orchestrates, it tries to tolerate extremely old Python versions. 3.6 was tested once
6-
# but the CI can only reach 3.7
7-
requires-python = ">= 3.7"
5+
# orchestrates, it tries to tolerate old Python versions
6+
requires-python = ">= 3.8"
87
[project.scripts]
98
jax-toolbox-triage = "jax_toolbox_triage:main"

.github/workflows/triage-ci.yaml

+2-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ on:
1616
push:
1717
branches:
1818
- main
19-
- olupton/triage # FIXME: remove
2019

2120
env:
2221
TRIAGE_PYTHON_FILES: .github/triage
@@ -40,11 +39,10 @@ jobs:
4039
run: |
4140
mypy .github/triage
4241
pytest:
43-
# Sticking on 22.04 keeps python 3.7 available
44-
runs-on: ubuntu-22.04
42+
runs-on: ubuntu-24.04
4543
strategy:
4644
matrix:
47-
PYTHON_VERSION: ["3.7", "3.12"]
45+
PYTHON_VERSION: ["3.8", "3.12"]
4846
fail-fast: false
4947
steps:
5048
- name: Check out the repository under ${GITHUB_WORKSPACE}

0 commit comments

Comments
 (0)