Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 8082c3b

Browse files
author
Md Khan
committedFeb 2, 2024
added functionality tests for upstream-maxtext
1 parent 5a8c8a9 commit 8082c3b

File tree

2 files changed

+48
-6
lines changed

2 files changed

+48
-6
lines changed
 

‎.github/workflows/_ci.yaml

+13-2
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ jobs:
140140
- build-pax
141141
- build-rosetta-t5x
142142
- build-rosetta-pax
143+
- build-maxtext
143144
outputs:
144145
CONTAINER_TAGS: ${{ steps.save-docker-tags.outputs.CONTAINER_TAGS }}
145146
steps:
@@ -159,7 +160,9 @@ jobs:
159160
"tag-t5x-mealkit": "${{ needs.build-rosetta-t5x.outputs.DOCKER_TAG_MEALKIT }}", \
160161
"tag-t5x-final": "${{ needs.build-rosetta-t5x.outputs.DOCKER_TAG_FINAL }}", \
161162
"tag-pax-mealkit": "${{ needs.build-rosetta-pax.outputs.DOCKER_TAG_MEALKIT }}", \
162-
"tag-pax-final": "${{ needs.build-rosetta-pax.outputs.DOCKER_TAG_FINAL }}" \
163+
"tag-pax-final": "${{ needs.build-rosetta-pax.outputs.DOCKER_TAG_FINAL }}", \
164+
"tag-upstream-maxtext-mealkit": "${{ needs.build-maxtext.outputs.DOCKER_TAG_MEALKIT }}", \
165+
"tag-upstream-maxtext-final": "${{ needs.build-maxtext.outputs.DOCKER_TAG_FINAL }}" \
163166
}
164167
EOF
165168
@@ -243,7 +246,15 @@ jobs:
243246
with:
244247
PAX_IMAGE: ${{ needs.build-rosetta-pax.outputs.DOCKER_TAG_FINAL }}
245248
secrets: inherit
246-
249+
250+
test-upstream-maxtext:
251+
needs: build-maxtext
252+
if: inputs.ARCHITECTURE == 'amd64' # no images for arm64
253+
uses: ./.github/workflows/_test_maxtext.yaml
254+
with:
255+
MAXTEXT_IMAGE: ${{ needs.build-maxtext.outputs.DOCKER_TAG_FINAL }}
256+
secrets: inherit
257+
247258
## TODO: uncomments when PR #463
248259
# test-levanter:
249260
# needs: build-levanter

‎.github/workflows/_sandbox.yaml

+35-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,41 @@
1-
name: ~Sandbox
1+
name: "~Sandbox"
22

33
on:
44
workflow_dispatch:
55

66
jobs:
7+
sandbox:
8+
runs-on: ubuntu-22.04
9+
steps:
10+
- name: Login to GitHub Container Registry
11+
uses: docker/login-action@v2
12+
with:
13+
registry: ghcr.io
14+
username: ${{ github.repository_owner }}
15+
password: ${{ secrets.GITHUB_TOKEN }}
716

8-
test-maxtext:
9-
uses: ./.github/workflows/_test_maxtext.yaml
10-
secrets: inherit
17+
- name: Print usage
18+
run: |
19+
cat << EOF
20+
This is an empty workflow file located in the main branch of your
21+
repository. It serves as a testing ground for new GitHub Actions on
22+
development branches before merging them to the main branch. By
23+
defining and overloading this workflow on your development branch,
24+
you can test new actions without affecting your main branch, ensuring
25+
a smooth integration process once the changes are ready to be merged.
26+
27+
Usage:
28+
29+
1. In your development branch, modify the sandbox.yml workflow file
30+
to include the new actions you want to test. Make sure to commit
31+
the changes to the development branch.
32+
2. Navigate to the 'Actions' tab in your repository, select the
33+
'~Sandbox' workflow, and choose your development branch from the
34+
branch dropdown menu. Click on 'Run workflow' to trigger the
35+
workflow on your development branch.
36+
3. Once you have tested and verified the new actions in the Sandbox
37+
workflow, you can incorporate them into your main workflow(s) and
38+
merge the development branch into the main branch. Remember to
39+
revert the changes to the sandbox.yml file in the main branch to
40+
keep it empty for future testing.
41+
EOF

0 commit comments

Comments
 (0)
Please sign in to comment.