Skip to content

Commit 48eb66d

Browse files
authored
Fix missing spaces in rsync commands (#1114)
Only the one in _test_slurm_pyxis.yaml is critical; others are cosmetic.
1 parent 56f9b80 commit 48eb66d

6 files changed

+33
-33
lines changed

.github/workflows/_test_maxtext.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,10 @@ jobs:
155155
shell: bash -x -e {0}
156156
run: |
157157
mkdir output/
158-
rsync -rtz --progress\
158+
rsync -rtz --progress \
159159
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
160160
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
161-
rsync -rtz --progress\
161+
rsync -rtz --progress \
162162
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
163163
output/ || true
164164
rsync -rtz --progress \
@@ -309,10 +309,10 @@ jobs:
309309
shell: bash -x -e {0}
310310
run: |
311311
mkdir output/
312-
rsync -rtz --progress\
312+
rsync -rtz --progress \
313313
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
314314
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
315-
rsync -rtz --progress\
315+
rsync -rtz --progress \
316316
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
317317
output/ || true
318318
rsync -rtz --progress \

.github/workflows/_test_pax_rosetta.yaml

+10-10
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,10 @@ jobs:
152152
run: |
153153
cd $GITHUB_WORKSPACE
154154
mkdir output/
155-
rsync -rtz --progress\
155+
rsync -rtz --progress \
156156
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
157157
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
158-
rsync -rtz --progress\
158+
rsync -rtz --progress \
159159
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
160160
output/ || true
161161
rsync -rtz --progress \
@@ -378,10 +378,10 @@ jobs:
378378
run: |
379379
cd $GITHUB_WORKSPACE
380380
mkdir output/
381-
rsync -rtz --progress\
381+
rsync -rtz --progress \
382382
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
383383
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
384-
rsync -rtz --progress\
384+
rsync -rtz --progress \
385385
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
386386
output/ || true
387387
rsync -rtz --progress \
@@ -573,10 +573,10 @@ jobs:
573573
run: |
574574
cd $GITHUB_WORKSPACE
575575
mkdir output/
576-
rsync -rtz --progress\
576+
rsync -rtz --progress \
577577
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
578578
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
579-
rsync -rtz --progress\
579+
rsync -rtz --progress \
580580
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
581581
output/ || true
582582
rsync -rtz --progress \
@@ -768,10 +768,10 @@ jobs:
768768
run: |
769769
cd $GITHUB_WORKSPACE
770770
mkdir output/
771-
rsync -rtz --progress\
771+
rsync -rtz --progress \
772772
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
773773
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
774-
rsync -rtz --progress\
774+
rsync -rtz --progress \
775775
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
776776
output/ || true
777777
rsync -rtz --progress \
@@ -958,10 +958,10 @@ jobs:
958958
run: |
959959
cd $GITHUB_WORKSPACE
960960
mkdir output/
961-
rsync -rtz --progress\
961+
rsync -rtz --progress \
962962
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
963963
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
964-
rsync -rtz --progress\
964+
rsync -rtz --progress \
965965
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
966966
output/ || true
967967
rsync -rtz --progress \

.github/workflows/_test_slurm_pyxis.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ jobs:
212212
shell: bash -x -e {0}
213213
run: |
214214
function rsync-down() {
215-
rsync -rtz --progress${{ secrets.SLURM_LOGIN_USER }}@${{ inputs.SLURM_LOGIN_HOSTNAME }}:$1 $2
215+
rsync -rtz --progress ${{ secrets.SLURM_LOGIN_USER }}@${{ inputs.SLURM_LOGIN_HOSTNAME }}:$1 $2
216216
}
217217
mkdir -p artifacts/
218218
rsync-down ${{ steps.meta.outputs.LOG_FILE }} artifacts/

.github/workflows/_test_t5x_rosetta.yaml

+8-8
Original file line numberDiff line numberDiff line change
@@ -159,10 +159,10 @@ jobs:
159159
run: |
160160
cd $GITHUB_WORKSPACE
161161
mkdir output/
162-
rsync -rtz --progress\
162+
rsync -rtz --progress \
163163
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
164164
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
165-
rsync -rtz --progress\
165+
rsync -rtz --progress \
166166
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
167167
output/ || true
168168
rsync -rtz --progress \
@@ -355,10 +355,10 @@ jobs:
355355
run: |
356356
cd $GITHUB_WORKSPACE
357357
mkdir output/
358-
rsync -rtz --progress\
358+
rsync -rtz --progress \
359359
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
360360
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
361-
rsync -rtz --progress\
361+
rsync -rtz --progress \
362362
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
363363
output/ || true
364364
rsync -rtz --progress \
@@ -524,10 +524,10 @@ jobs:
524524
run: |
525525
cd $GITHUB_WORKSPACE
526526
mkdir output/
527-
rsync -rtz --progress\
527+
rsync -rtz --progress \
528528
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
529529
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
530-
rsync -rtz --progress\
530+
rsync -rtz --progress \
531531
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
532532
output/ || true
533533
rsync -rtz --progress \
@@ -697,10 +697,10 @@ jobs:
697697
run: |
698698
cd $GITHUB_WORKSPACE
699699
mkdir output/
700-
rsync -rtz --progress\
700+
rsync -rtz --progress \
701701
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
702702
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
703-
rsync -rtz --progress\
703+
rsync -rtz --progress \
704704
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
705705
output/ || true
706706
rsync -rtz --progress \

.github/workflows/_test_upstream_pax.yaml

+6-6
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,10 @@ jobs:
147147
shell: bash -x -e {0}
148148
run: |
149149
mkdir output/
150-
rsync -rtz --progress\
150+
rsync -rtz --progress \
151151
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
152152
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
153-
rsync -rtz --progress\
153+
rsync -rtz --progress \
154154
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
155155
output/ || true
156156
rsync -rtz --progress \
@@ -325,10 +325,10 @@ jobs:
325325
shell: bash -x -e {0}
326326
run: |
327327
mkdir output/
328-
rsync -rtz --progress\
328+
rsync -rtz --progress \
329329
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
330330
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
331-
rsync -rtz --progress\
331+
rsync -rtz --progress \
332332
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
333333
output/ || true
334334
rsync -rtz --progress \
@@ -472,10 +472,10 @@ jobs:
472472
shell: bash -x -e {0}
473473
run: |
474474
mkdir output/
475-
rsync -rtz --progress\
475+
rsync -rtz --progress \
476476
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
477477
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
478-
rsync -rtz --progress\
478+
rsync -rtz --progress \
479479
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
480480
output/ || true
481481
rsync -rtz --progress \

.github/workflows/_test_upstream_t5x.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -150,10 +150,10 @@ jobs:
150150
shell: bash -x -e {0}
151151
run: |
152152
mkdir output/
153-
rsync -rtz --progress\
153+
rsync -rtz --progress \
154154
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
155155
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
156-
rsync -rtz --progress\
156+
rsync -rtz --progress \
157157
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
158158
output/ || true
159159
rsync -rtz --progress \
@@ -298,10 +298,10 @@ jobs:
298298
run: |
299299
300300
mkdir output/
301-
rsync -rtz --progress\
301+
rsync -rtz --progress \
302302
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.LOG_FILE }} \
303303
output/${{ steps.meta.outputs.TEST_CASE_NAME }}.log || true
304-
rsync -rtz --progress\
304+
rsync -rtz --progress \
305305
${{ secrets.CLUSTER_LOGIN_USER }}@${{ vars.HOSTNAME_SLURM_LOGIN }}:${{ steps.meta.outputs.MODEL_PATH }}/* \
306306
output/ || true
307307
rsync -rtz --progress \

0 commit comments

Comments
 (0)