Skip to content

Commit 2339190

Browse files
authored
Merge branch 'main' into vkozlov/fix-levanter-tests-3
2 parents 19e9c1d + e8043a5 commit 2339190

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

.github/container/Dockerfile.pax.amd64

+3
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ for src in ${SRC_PATH_PAXML} ${SRC_PATH_PRAXIS}; do
2929
pushd ${src}
3030
sed -i "s| @ git+https://github.com/google/flax||g" requirements.in
3131
sed -i "s| @ git+https://github.com/google/jax||g" requirements.in
32+
## we pin etils because newer etils versions are not compatible with the
33+
## version of TFDS required by Pax
34+
sed -i "s/etils/etils==1.7.0/g" requirements.in
3235
if git diff --quiet; then
3336
echo "URL specs no longer present in select dependencies for ${src}"
3437
exit 1

.github/container/test-jax.sh

-3
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,6 @@ else
109109
fi
110110

111111
for t in $*; do
112-
if [[ "$t" != "//tests:"* ]]; then
113-
t="//tests:${t}"
114-
fi
115112
BAZEL_TARGET="${BAZEL_TARGET} $t"
116113
done
117114

.github/workflows/_ci.yaml

+3-2
Original file line numberDiff line numberDiff line change
@@ -528,13 +528,14 @@ jobs:
528528
STATISTICS_SCRIPT: |
529529
summary_line=$(tail -n1 test-te.log)
530530
errors=$(echo $summary_line | grep -oE '[0-9]+ error' | awk '{print $1} END { if (!NR) print 0}')
531-
passed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "CollectReport" and .outcome == "passed") | .outcome' | wc -l)
532-
failed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "CollectReport" and .outcome == "failed") | .outcome' | wc -l)
531+
passed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "TestReport" and .when == "call" and .outcome == "passed") | .outcome' | wc -l)
532+
failed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "TestReport" and .when == "call" and .outcome == "failed") | .outcome' | wc -l)
533533
total_tests=$((failed_tests + passed_tests))
534534
echo "TOTAL_TESTS=${total_tests}" >> $GITHUB_OUTPUT
535535
echo "ERRORS=${errors}" >> $GITHUB_OUTPUT
536536
echo "PASSED_TESTS=${passed_tests}" >> $GITHUB_OUTPUT
537537
echo "FAILED_TESTS=${failed_tests}" >> $GITHUB_OUTPUT
538+
TIMEOUT_MINUTES: 120
538539
ARTIFACTS: |
539540
test-te.log
540541
pytest-report.jsonl

.github/workflows/_test_unit.yaml

+6-1
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,18 @@ on:
1919
type: string
2020
description: 'Test artifacts to collect'
2121
required: false
22+
TIMEOUT_MINUTES:
23+
type: number
24+
description: 'Maximum test runtime, in minutes'
25+
default: 60
2226

2327
jobs:
2428
runner:
2529
uses: ./.github/workflows/_runner_ondemand_slurm.yaml
2630
with:
2731
NAME: "A100"
2832
LABELS: "A100,${{ github.run_id }}"
29-
TIME: "01:00:00"
33+
TIME: "${{ inputs.TIMEOUT_MINUTES }}:00"
3034
secrets: inherit
3135

3236
run-unit-test:
@@ -67,6 +71,7 @@ jobs:
6771
- name: Run tests
6872
shell: bash -x -e {0}
6973
continue-on-error: true
74+
timeout-minutes: ${{ inputs.TIMEOUT_MINUTES }}
7075
run: |
7176
${{ inputs.EXECUTE }}
7277

0 commit comments

Comments
 (0)