Skip to content

Commit 070fe29

Browse files
committed
Merge branch 'emma/correct_comment_datapath' into 'main'
Update some comments and datapath See merge request dl/hugectr/hugectr!1532
2 parents e369846 + 5c566e6 commit 070fe29

File tree

5 files changed

+5
-8
lines changed

5 files changed

+5
-8
lines changed

CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ if (DISABLE_A2A_WARMUP)
122122
endif()
123123

124124
option(DISABLE_CUDF "Disable cudf: disable parquet format related features" OFF)
125-
# this manual definition is a WAR and RMM team will fix it in the future
125+
# Add this manual definition
126126
add_compile_definitions(LIBCUDACXX_ENABLE_EXPERIMENTAL_MEMORY_RESOURCE)
127127
option(USE_CUDART_STATIC "Setup clangformat target" OFF)
128128
if(USE_CUDART_STATIC)

HugeCTR/src/hps/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ list(APPEND huge_ctr_hps_src
3030
"../io/gcs_filesystem.cpp"
3131
)
3232

33-
# this manual definition is a WAR and RMM team will fix it in the future
33+
# Add this manual definition
3434
add_compile_definitions(LIBCUDACXX_ENABLE_EXPERIMENTAL_MEMORY_RESOURCE)
3535

3636
add_library(huge_ctr_hps SHARED ${huge_ctr_hps_src})

sbin/build-hadoop.sh

-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ if [[ "${HDFS_BUILD_MODE}" == "MINIMAL" ]]; then
4343
cd hadoop-hdfs-project/hadoop-hdfs-native-client
4444
fi
4545

46-
# WAR for https://issues.apache.org/jira/browse/YARN-11528
4746
# TODO: remove below lines when the fix released.
4847
sed -i '/scripts/i \
4948
\"resolutions\": { \

test/utest/data_reader/data_reader_benchmark.cu

-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ using namespace HugeCTR;
3434

3535
// const std::string fname = "/40m.limit_preshuffled/train_data.bin";
3636
// const std::string fname = "/criteo_kaggle/dlrm/test_data.bin";
37-
// const std::string fname = "/raid/datasets/criteo/mlperf/40m.limit_preshuffled/train_data.bin";
3837
const std::string fname = "/data_multihot/val_data.bin";
3938

4039
__global__ void gpu_sleep(int64_t num_cycles) {

test/utest/embedding_collection/configuration.hpp

+3-4
Original file line numberDiff line numberDiff line change
@@ -374,10 +374,9 @@ InputDataConfiguration synthetic_uniform_dataset = {.fixed_hotness = true,
374374
InputDataConfiguration criteo_dataset = {
375375
.fixed_hotness = true,
376376
.input_data_type = InputDataType::RawFormat,
377-
.raw_format_param = {
378-
.input_file = "/raid/datasets/criteo/mlperf/40m.limit_preshuffled/train_data.bin",
379-
.label_dim = 1,
380-
.dense_dim = 13}};
377+
.raw_format_param = {.input_file = "/datasets/40m.limit_preshuffled/train_data.bin",
378+
.label_dim = 1,
379+
.dense_dim = 13}};
381380

382381
InputDataConfiguration criteo_multi_hot_dataset = {
383382
.fixed_hotness = true,

0 commit comments

Comments
 (0)