Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert parm/configs from @TEMPLATE@ to Jinja {{ TEMPLATE }} #3404

Open
3 tasks
aerorahul opened this issue Feb 27, 2025 · 0 comments
Open
3 tasks

Convert parm/configs from @TEMPLATE@ to Jinja {{ TEMPLATE }} #3404

aerorahul opened this issue Feb 27, 2025 · 0 comments
Assignees

Comments

@aerorahul
Copy link
Contributor

What new functionality do you need?

The experiment config files under parm/config/<system>/config.* are templated in the format @TEMPLATE@.
setup_expt.py as a result has to do extra work mapping the keys from the yaml's providing the defaults to match these keys. This adds unnecessary complexity and custom code that can be easily replaced by using standard Jinja templating. This effort translates to users unfamiliar with the inner workings of the global-workflow.

What are the requirements for the new functionality?

  • Use standard templating practices e.g. jinja instead of ad hock methods while maintaining existing functionality.

Acceptance Criteria

  • All @TEMPLATE@ type appearances from config.* are replaced w/ {{ TEMPLATE }}
  • Experiment directories generated before and after this change are identical for all the test cases
  • XML's generated before and after this change are identical for all test cases

Suggest a solution (optional)

No response

@aerorahul aerorahul added the triage Issues that are triage label Feb 27, 2025
@aerorahul aerorahul self-assigned this Feb 27, 2025
@aerorahul aerorahul removed the triage Issues that are triage label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant