Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSUN_REF FITS keyword #301

Open
1 task
mgalloy opened this issue Oct 1, 2024 · 2 comments
Open
1 task

Add RSUN_REF FITS keyword #301

mgalloy opened this issue Oct 1, 2024 · 2 comments
Assignees
Labels
bug fix of a problem in the existing code docs needs documentation metadata-changing issue will change FITS keywords, filenames etc. questions coding is stoppped to determine correct path
Milestone

Comments

@mgalloy
Copy link
Member

mgalloy commented Oct 1, 2024

I need a value for RSUN_REF for the UCoMP wave regions. See discussion in KCor issue 360 about this value for KCor. This is needed for SunPy to display a UCoMP image without warnings.

Also see SunPy docs about RSUN: The role of “rsun” in sunpy.

Questions

  • Are the values listed below OK? These are values of the closest wavelength in the top half of Table 2 from the paper Joan gives.
@mgalloy mgalloy added bug fix of a problem in the existing code docs needs documentation metadata-changing issue will change FITS keywords, filenames etc. labels Oct 1, 2024
@mgalloy mgalloy added this to the UCoMP 1.1 milestone Oct 1, 2024
@mgalloy mgalloy self-assigned this Oct 1, 2024
@jburkepile
Copy link

jburkepile commented Oct 2, 2024

Here is a paper that appears to have determination of the radius of the solar photosphere vs. wavelength.

@mgalloy
Copy link
Member Author

mgalloy commented Oct 2, 2024

Tentative keyword and comment, for example for 1074 nm:

RSUN_REF=          696136000.0 / [m] solar radius at 1025.0 nm

Using these values from the paper, for 530 nm:

solar_radius                     : type=float, default=696096000.0
solar_radius_wavelength          : type=float, default=535.7

For 637 nm:

solar_radius                     : type=float, default=696157000.0
solar_radius_wavelength          : type=float, default=607.1

For 656 nm:

solar_radius                     : type=float, default=696157000.0
solar_radius_wavelength          : type=float, default=607.1

For 670 nm:

solar_radius                     : type=float, default=696157000.0
solar_radius_wavelength          : type=float, default=607.1

For 691 nm:

solar_radius                     : type=float, default=696157000.0
solar_radius_wavelength          : type=float, default=607.1

For 706 nm:

solar_radius                     : type=float, default=696168000.0
solar_radius_wavelength          : type=float, default=782.1

For 761 nm:

solar_radius                     : type=float, default=696168000.0
solar_radius_wavelength          : type=float, default=782.1

For 789 nm:

solar_radius                     : type=float, default=696168000.0
solar_radius_wavelength          : type=float, default=782.1

For 802 nm:

solar_radius                     : type=float, default=696168000.0
solar_radius_wavelength          : type=float, default=782.1

For 991 nm:

solar_radius                     : type=float, default=696136000.0
solar_radius_wavelength          : type=float, default=1025.0

For 1074 nm:

solar_radius                     : type=float, default=696136000.0
solar_radius_wavelength          : type=float, default=1025.0

For 1079 nm:

solar_radius                     : type=float, default=696136000.0
solar_radius_wavelength          : type=float, default=1025.0

For 1083 nm:

solar_radius                     : type=float, default=696136000.0
solar_radius_wavelength          : type=float, default=1025.0

mgalloy added a commit that referenced this issue Oct 2, 2024
mgalloy added a commit that referenced this issue Oct 3, 2024
@mgalloy mgalloy added the questions coding is stoppped to determine correct path label Oct 4, 2024
mgalloy added a commit that referenced this issue Oct 15, 2024
mgalloy added a commit that referenced this issue Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix of a problem in the existing code docs needs documentation metadata-changing issue will change FITS keywords, filenames etc. questions coding is stoppped to determine correct path
Projects
None yet
Development

No branches or pull requests

2 participants