Update core-build-tasks to partially bundle in order to handle ESM only

dependencies from commonjs invocations. Add release publishing task to
core-build-tasks and integrate it into minecraft math so that the pre-built
bundle is included in releases. Integrate this release publish into the
release pipeline.

Author: rlandav

.github/workflows/pull-request.yml

@@ -4,9 +4,6 @@ on:
   pull_request:
     branches:
       - main
-  push:
-    branches:
-      - rlanda/testPipeline
 
 jobs:
   build:
@@ -19,6 +16,4 @@ jobs:
         with:
           node-version: 20
       - run: npm ci
-      - run: npm run test
-        env:
-            TEST_VAR: 'CheckVarFromJust'
+      - run: npm run test

.github/workflows/release-changes.yml

@@ -18,8 +18,6 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: 20
-      - name: GH Release
-        uses: softprops/[email protected]
       - run: npm ci
       - run: npm run test # Fully build the repo so we have artifacts available to create releases, include tests so we don't ship in a broken state
 
@@ -36,4 +34,5 @@ jobs:
       - name: Publish
         run: npm run release -- --token "$NPM_TOKEN" --yes --new
         env:
-          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+          REPO_PAT: ${{ secrets.REPO_PAT }}

.gitignore

@@ -4,4 +4,5 @@ lib-cjs
 dist
 temp
 node_modules
-*.tgz
+*.tgz
+*.zip

.vscode/launch.json

@@ -1,7 +1,7 @@
 {
-  "type": "major",
-  "comment": "Export both ESM and CJS, but exclusively use CJS for just task configuration",
-  "packageName": "@minecraft/core-build-tasks",
-  "email": "[email protected]",
-  "dependentChangeType": "patch"
+    "type": "major",
+    "comment": "Export both ESM and CJS, but exclusively use CJS for just task configuration. Pre-bundle most dependencies to deal with ESM exclusive dependencies",
+    "packageName": "@minecraft/core-build-tasks",
+    "email": "[email protected]",
+    "dependentChangeType": "patch"
 }

change/@minecraft-core-build-tasks-f422a1d3-0607-48c5-a390-fe2f93713af0.json

@@ -1,7 +1,7 @@
 {
-  "type": "major",
-  "comment": "Switch to ESM exclusively",
-  "packageName": "@minecraft/math",
-  "email": "[email protected]",
-  "dependentChangeType": "patch"
+    "type": "major",
+    "comment": "Switch to ESM exclusively. Publish release with artifacts.",
+    "packageName": "@minecraft/math",
+    "email": "[email protected]",
+    "dependentChangeType": "major"
 }

change/@minecraft-math-7b3a5de1-838b-46a5-acb6-9cdeddefff32.json

@@ -1,7 +1,7 @@
 {
-  "type": "major",
-  "comment": "Switch to CJS exclusively, and update to ESLint 9",
-  "packageName": "eslint-plugin-minecraft-linting",
-  "email": "[email protected]",
-  "dependentChangeType": "patch"
+    "type": "major",
+    "comment": "Switch to CJS exclusively, and update to ESLint 9",
+    "packageName": "eslint-plugin-minecraft-linting",
+    "email": "[email protected]",
+    "dependentChangeType": "major"
 }

change/eslint-plugin-minecraft-linting-a958326b-c769-47f3-9670-d7f8edf651ee.json

@@ -5,8 +5,11 @@ import {
     apiExtractorTask,
     cleanTask,
     coreLint,
+    publishReleaseTask,
     vitestTask,
 } from '@minecraft/core-build-tasks';
+import { copyFileSync, createWriteStream, readFileSync } from 'node:fs';
+import { resolve } from 'node:path';
 
 const isOnlyBuild = argv()._.findIndex(arg => arg === 'test') === -1;
 
@@ -20,18 +23,30 @@ task('bundle', () => {
     execSync(
         'npx esbuild ./lib/index.js --bundle --outfile=dist/minecraft-math.js --format=esm --sourcemap --external:@minecraft/server'
     );
+    // Copy over type definitions and rename
+    const officialTypes = JSON.parse(readFileSync('./package.json', 'utf-8'))['types'];
+    if (!officialTypes) {
+        // Has the package.json been restructured?
+        throw new Error('The package.json file does not contain a "types" field. Unable to copy types to bundle.');
+    }
+    const officialTypesPath = resolve(officialTypes);
+    copyFileSync(officialTypesPath, './dist/minecraft-math.d.ts');
 });
 task('build', series('typescript', 'api-extractor-local', 'bundle'));
 
-// Post-build test to confirm environment variable propagates through various build scripts
-task('postbuild', () => {
-    console.log(`The environment variable TEST_VAR is set to: ${process.env.TEST_VAR}`);
-});
-
 // Test
 task('api-extractor-validate', apiExtractorTask('./api-extractor.json', isOnlyBuild /* localBuild */));
 task('vitest', vitestTask());
 task('test', series('api-extractor-validate', 'vitest'));
 
 // Clean
 task('clean', cleanTask(DEFAULT_CLEAN_DIRECTORIES));
+
+// Post-publish
+task('postpublish', () => {
+    return publishReleaseTask({
+        repoOwner: 'Mojang',
+        repoName: 'minecraft-scripting-libraries',
+        message: 'See attached zip for pre-built minecraft-math bundle with type declarations.',
+    });
+});

libraries/math/just.config.cts

@@ -21,10 +21,10 @@
     },
     "scripts": {
         "build": "just build",
-        "postbuild": "just postbuild",
         "lint": "just lint",
         "test": "just test",
-        "clean": "just clean"
+        "clean": "just clean",
+        "postpublish": "just postpublish"
     },
     "license": "MIT",
     "files": [