Adding linting check for core-build-task (#28)

* - Adding basic linting to core-build-tasks

* Change files

* - Dummy change

* - Fixing prettier config

* - Reverting readme file changes

* - Using gitattributes file instead.

* - Using endOfLine auto again

* - Fixing nit for the task

Author: frgarc

.vscode/settings.json

@@ -0,0 +1,11 @@
+{
+    "eslint.experimental.useFlatConfig": true,
+    "eslint.workingDirectories": [
+        {
+            "pattern": "./libraries/*/"
+        },
+        {
+            "pattern": "./tools/*/"
+        }
+    ]
+}

change/@minecraft-core-build-tasks-268ae585-2ff5-4e08-8d7a-de34c01ca869.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "- Adding basic linting to core-build-tasks",
+  "packageName": "@minecraft/core-build-tasks",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@minecraft-math-4ca66802-83ea-472e-b2ea-b8ba47e0bcb0.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "Enabling prettier check",
+  "packageName": "@minecraft/math",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

libraries/math/package.json

@@ -36,6 +36,7 @@
     "@minecraft/core-build-tasks": "*",
     "@minecraft/tsconfig": "*",
     "just-scripts": "^2.2.1",
+    "prettier": "^2.8.2",
     "vitest": "^0.34.6"
   }
-}
+}

libraries/math/src/vector3/coreHelpers.test.ts

@@ -178,9 +178,9 @@ describe('Vector3 operations', () => {
 
     it('calculates the lerp halfway between two vectors', () => {
         const result: Vector3 = Vector3Utils.lerp(v1, v2, 0.5);
-        expect(result).toEqual({ x: 2.5, y: 3.5, z: 4.5});
+        expect(result).toEqual({ x: 2.5, y: 3.5, z: 4.5 });
     });
-  
+
     it('calculates the slerp halfway between two vectors', () => {
         const vecA: Vector3 = { x: 1, y: 0, z: 0 };
         const vecB: Vector3 = { x: 0, y: -1, z: 0 };

libraries/math/src/vector3/coreHelpers.ts

@@ -125,7 +125,7 @@ export class Vector3Utils {
         limits?: {
             min?: Partial<Vector3>;
             max?: Partial<Vector3>;
-        },
+        }
     ): Vector3 {
         return {
             x: clampNumber(v.x, limits?.min?.x ?? Number.MIN_SAFE_INTEGER, limits?.max?.x ?? Number.MAX_SAFE_INTEGER),
@@ -154,10 +154,10 @@ export class Vector3Utils {
      */
     static slerp(a: Vector3, b: Vector3, t: number): Vector3 {
         const theta = Math.acos(Vector3Utils.dot(a, b));
-		const sinTheta = Math.sin(theta);
-		const ta = Math.sin((1.0 - t) * theta) / sinTheta;
-		const tb = Math.sin(t * theta) / sinTheta;
-		return Vector3Utils.add(Vector3Utils.scale(a, ta), Vector3Utils.scale(b, tb));
+        const sinTheta = Math.sin(theta);
+        const ta = Math.sin((1.0 - t) * theta) / sinTheta;
+        const tb = Math.sin(t * theta) / sinTheta;
+        return Vector3Utils.add(Vector3Utils.scale(a, ta), Vector3Utils.scale(b, tb));
     }
 }
 
@@ -279,4 +279,3 @@ export const VECTOR3_NORTH: Vector3 = { x: 0, y: 0, z: 1 };
  * @public
  */
 export const VECTOR3_SOUTH: Vector3 = { x: 0, y: 0, z: -1 };
-

libraries/math/src/vector3/vectorWrapper.test.ts

@@ -170,7 +170,7 @@ describe('Vector3Builder', () => {
         const resultB = vectorA.lerp(vectorB, ratio);
         expect(resultA).toEqual(resultB);
     });
-    
+
     it('should be able compute the slerp halfway between two vectors with the same result as the coreHelpers function', () => {
         const vectorA = new Vector3Builder(5, 6, 3);
         const vectorB = new Vector3Builder(4, 2, 6);

libraries/math/src/vector3/vectorWrapper.ts

@@ -150,7 +150,6 @@ export class Vector3Builder implements Vector3 {
         return this.assign(Vector3Utils.clamp(this, limits));
     }
 
-    
     /**
      * lerp
      *
@@ -165,7 +164,7 @@ export class Vector3Builder implements Vector3 {
      *
      * Constructs a new vector using spherical linear interpolation on each component from two vectors.
      */
-    slerp(vec: Vector3, t: number): this { 
+    slerp(vec: Vector3, t: number): this {
         return this.assign(Vector3Utils.slerp(this, vec, t));
     }
 }

package-lock.json

@@ -1,7 +1,7 @@
 module.exports = {
     arrowParens: 'avoid',
     bracketSpacing: true,
-    endOfLine: 'crlf',
+    endOfLine: 'auto',
     printWidth: 120,
     singleQuote: true,
     tabWidth: 4,

prettier.config.js

@@ -0,0 +1,21 @@
+import globals from 'globals';
+import tsParser from '@typescript-eslint/parser';
+
+export default [
+    {
+        files: ['**/*.{ts,tsx,js,jsx}', '*.ts'],
+        languageOptions: {
+            parser: tsParser,
+            parserOptions: {
+                ecmaVersion: 'latest',
+                project: './tsconfig.json',
+            },
+            globals: {
+                ...globals.node,
+            },
+        },
+        rules: {
+            eqeqeq: ['error', 'always'],
+        },
+    },
+];