Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] (autogen.sh) improve POTFILES.in creating #4619

Open
mc-butler opened this issue Dec 17, 2024 · 4 comments
Open

[PATCH] (autogen.sh) improve POTFILES.in creating #4619

mc-butler opened this issue Dec 17, 2024 · 4 comments
Labels
area: build Build system and (cross-)compilation prio: low Minor problem or easily worked around
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4619
Reporter and
  • current POTFILES.in file detection can output wrong filename

xgettext output
#: src/background.c:221 src/filemanager/file.c:858 src/filemanager/file.c:952
result in
src/background.csrc/filemanager/file.csrc/filemanager/file.c

  • simplify POTFILES.in file detection by using grep only
  • find command search files only
  • find/grep option should be Solaris OS friendly (please verify)
  • move POTFILES.in creating to configure.ac (more BUILD friendly and future autogen.sh get rid possibility)
  • autoconf AC_CONFIG_COMMANDS_POST support since <2.64
  • comparing current vs simplify grep file detection result in additional files:

lib/search/regex.c
lib/widget/history.c
lib/widget/quick.h
src/diffviewer/internal.h
src/diffviewer/search.c
src/editor/editdraw.c
src/editor/etags.c
src/filemanager/command.c
src/vfs/tar/tar.c
src/viewer/lib.c
tests/src/executecommon.c
tests/src/execute
execute_with_vfs_arg.c

Note

Original attachments:

@mc-butler
Copy link
Author

Changed by and on Dec 17, 2024 at 15:57 UTC

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Dec 17, 2024 at 19:06 UTC (comment 1)

  • Milestone changed from Future Releases to 4.8.33

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Dec 25, 2024 at 13:32 UTC (comment 2)

The build on Solaris seems to pass:

https://github.com/MidnightCommander/mc/actions/runs/12491592796/job/34857805295

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jan 9, 2025 at 10:58 UTC (comment 3)

  • Milestone changed from 4.8.33 to 4.8.34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build system and (cross-)compilation prio: low Minor problem or easily worked around
Development

No branches or pull requests

1 participant