Skip to content

Commit b8ca454

Browse files
committed
Show the variable path more subtly
When showing multiple variables in the tree display, this makes it easier to scan the display for the value vs the path. Bug: #126
1 parent f27fd0c commit b8ca454

File tree

2 files changed

+21
-5
lines changed

2 files changed

+21
-5
lines changed

extensions/tree-inspector/field-selector/field-selector.css

+8
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,14 @@
6868
display:block;
6969
}
7070

71+
.var-path {
72+
font-style: italic;
73+
}
74+
75+
.var-path-prefix {
76+
color: grey;
77+
}
78+
7179
input.small-input {
7280
font-size:8pt;
7381
margin-right:0.3em;

extensions/tree-inspector/field-selector/field-selector.js

+13-5
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ var FieldSelector = (function() {
174174
} else {
175175
this.typeListContainer.appendChild(newTypeContainer);
176176
}
177-
177+
178178
var that = this;
179179
var enabledPaths = this.checkedFields.getEnabledPaths(type);
180180
return Promise.map(enabledPaths, function (path) { return explorer.enableField(path, /*context*/true); })
@@ -325,17 +325,25 @@ var FieldSelector = (function() {
325325
FieldSelectorController.prototype._createRenderer = function(field) {
326326
function insertFieldList(names, container) {
327327
var fieldList = document.createElement("span");
328+
fieldList.classList.add("var-path");
328329
container.appendChild(fieldList);
329-
fieldList.textContent = names.join(".") + ":";
330+
if (names.length > 1) {
331+
var pathPrefix = names.slice(0, -1);
332+
var pathPrefixList = document.createElement("span");
333+
fieldList.appendChild(pathPrefixList);
334+
pathPrefixList.classList.add("var-path-prefix");
335+
pathPrefixList.textContent = pathPrefix.join(".") + ".";
336+
}
337+
fieldList.appendChild(document.createTextNode(names[names.length - 1] + ":"));
330338
}
331339

332340
return function (dbgObject, element) {
333341
return Promise.resolve(null)
334342
.then(function() {
335343
var valueContainer = document.createElement("span");
336344
return DbgObject.render(
337-
field.getter(dbgObject),
338-
valueContainer,
345+
field.getter(dbgObject),
346+
valueContainer,
339347
function (dbgObject) {
340348
if (dbgObject.type.isArray()) {
341349
return dbgObject.array();
@@ -524,4 +532,4 @@ var FieldSelector = (function() {
524532

525533
TreeReader: FieldTreeReader
526534
};
527-
})();
535+
})();

0 commit comments

Comments
 (0)