-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The new search UI in the JSON viewer should show current index and total matches AND the old search field shouldn't appear #222
Comments
Thanks for filing @imba-tjd. I know that there's been some work on search lately, so this might be related. Just to make sure I understand: you're saying that the "xxx/200" counter is missing, but apart from this, search works, right? |
I mean the total number isn't correct. For example |
Thanks for clarifying, I was able to reproduce the issue. If others want to test this, you can use the following URL (just copy the whole string, paste it into the address bar, and press Enter):
Now, there are 2 ways to search:
My understanding is that, for performance reasons, the JSON viewer only renders what's visible in the viewport, and then renders more content as you scroll. This is why the usual browser search field can't find the total number of instances. These instances simply don't exist in the DOM yet. The new search UI (first screenshot above) is, I think, supposed to replace the browser search field in the JSON viewer. So I think this issue is really about two things:
|
["aaa", "aaa", ...]
if there are 200 "aaa", use Ctrl+F to search aaa, it won't show xxx/200
Or, the other way around: the usual browser search field should just work with the JSON viewer, and the new search UI should be removed. |
Closing since JSON Viewer has been deprecated and removed from Microsoft Edge. |
Originally posted by @imba-tjd in #87 (comment)
AB#47800890
The text was updated successfully, but these errors were encountered: