Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository is inconsistent with the MSLearn module #1

Open
Zenulous opened this issue Sep 16, 2019 · 2 comments
Open

Repository is inconsistent with the MSLearn module #1

Zenulous opened this issue Sep 16, 2019 · 2 comments

Comments

@Zenulous
Copy link

This concerns the section Extend continuous integration to source control by using a Container Registry task of the MSLearn unit Update the image and automatically redeploy the web app in Deploy and run a containerized web app with Azure App Service .

Because there is now a dotnet folder, the bash script az acr task create --registry <container_registry_name> --name buildwebapp --image webimage --context https://github.com/MicrosoftDocs/mslearn-deploy-run-container-app-service.git --branch master --file Dockerfile --git-access-token <access_token> does not work any longer because the Dockerfile will not be found this way.

There are 2 possible solutions:

  1. The documentation of MSLearn is updated to run the right Dockerfile
  2. The Dockerfile is moved to the root of the repository (and is updated accordingly)
@kossytony
Copy link

kossytony commented Oct 14, 2020

This is an update on the above issue.

  1. The documentation (https://docs.microsoft.com/en-us/cli/azure/acr/task?view=azure-cli-latest#az_acr_task_create) does not include the parameter --branch anymore, which leads to a failure error, "unrecognized arguments"

  2. To run the az cli command, the parameter --file requires an arg which is the relative path of the dockerfile file(for the node app the path is node/Dockerfile). You need to edit the copy function in the Dockerfile COPY /node/. /app
    In the case of the node app the command that works is;

az acr task create --registry <container_registry_name> --name buildwebapp --image webimage --context https://github.com/MicrosoftDocs/mslearn-deploy-run-container-app-service.git --file node/Dockerfile --git-access-token <access_token>

@AllenVisser
Copy link

AllenVisser commented Jan 29, 2021

Please fix this. How do you release | update Microsoft training material that doesnt work?
I had to copy this to my own Github to get it working, in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants