Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we continue supporting radix submodule creation through aljibe assistant? #28

Open
omarlopesino opened this issue Dec 10, 2024 · 1 comment

Comments

@omarlopesino
Copy link
Member

I've created this issue so we review the radix implementation in Aljibe. Currently, when aljibe assistant command is run, it offers creating a Radix subtheme. This is great but there is an internal initiative that proposes using Artisan instead: https://www.drupal.org/project/artisan

What should be do? I propose choosing one of these:

  1. Recommended: Stop supporting subthemes into aljibe, and just provide a basic infrastructure as an initial site. Themes and subthemes may be managed by other packages / recipes.
  2. Support artisan. This may lead to have this same issue years later if we change the theming solution.
  3. Remove temporarily subtheme support and reconsider this later with a more consolidated decision made along with all the team.

Personally, I recommend option 1. What do you think?

@juanjol
Copy link
Collaborator

juanjol commented Dec 12, 2024

Thank you for your contribution @omarlopesino!

The way I see it, it's clear that we need to finish Radix support. I contrasted it with the frontend colleagues and they all agree on it.

What I have my doubts about, is if we should remove support for subthemes. Since creating a subtheme is optional, and if artisan is installed it is only natural that a subtheme is required for development, I would keep it. Unless it can be done differently through recipes, which unfortunately I don't know, I think part of leaving a development environment ready to work is to leave a theme that is already editable by the user.

That said, my proposal is to remove radix, add artisan, and keep the option in the Aljibe wizard to generate a subtheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants