Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): add non evm balance #13948

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

wachunei
Copy link
Member

Description

This PR extends the useBalance hook of the Ramps folder to support CAIP-19 identifiers of the Ramp assets, currently Solana.

Related issues

Fixes:

Manual testing steps

  1. Go to Buy feature
  2. Reach the Build Quote View
  3. Solana balance must show up below the amount input

Screenshots/Recordings

Before After
image image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Mar 11, 2025
@wachunei wachunei added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 11, 2025
Copy link
Contributor

github-actions bot commented Mar 11, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f3d3fba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aacebcdc-984e-4cad-959b-b1ee80f94445

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 11, 2025
Copy link
Contributor

github-actions bot commented Mar 11, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 304df29
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/944d033b-37a0-4a2a-a218-97e6c4fac806

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@wachunei wachunei force-pushed the feat/ramp-non-evm-balance branch from 03ef951 to 8638db2 Compare March 11, 2025 16:41
@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 12, 2025
Copy link
Contributor

github-actions bot commented Mar 12, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7bd7db7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e74073b6-0896-4c4b-97c2-be3e36fc6404

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 12, 2025
Copy link
Contributor

github-actions bot commented Mar 12, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e2ddb4f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/54b1f519-39d2-4f4b-8424-3bd818c75a8f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 63.99%. Comparing base (d1d22d7) to head (e2ddb4f).
Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
app/components/UI/Ramp/hooks/useBalance.ts 0.00% 13 Missing ⚠️
...components/UI/Ramp/Views/BuildQuote/BuildQuote.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13948      +/-   ##
==========================================
+ Coverage   63.42%   63.99%   +0.56%     
==========================================
  Files        2093     2153      +60     
  Lines       45277    45929     +652     
  Branches     6234     6378     +144     
==========================================
+ Hits        28717    29390     +673     
+ Misses      14676    14632      -44     
- Partials     1884     1907      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants