Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lame-duck mode is not yet implemented #8

Open
Merovius opened this issue Nov 19, 2018 · 0 comments
Open

Lame-duck mode is not yet implemented #8

Merovius opened this issue Nov 19, 2018 · 0 comments
Labels
beta Issues that should be fixed or closed as wontfix in v0

Comments

@Merovius
Copy link
Owner

When the server is shutting down (by a cancelled context) it shouldn't just abort handling requests, but instead reply to them with ESHUTDOWN or NBD_REP_ERR_SHUTDOWN, until the client disconnects. This is unfortunate in that it means cancellation isn't immediate - if the client refuses to disconnect, Serve would block forever. Maybe we need a secondary cancellation signal for that.

Likewise, if the client receives an ESHUTDOWN or NBD_REP_ERR_SHUTDOWN response at any point, it should send an Abort/Disconnect.

Relevant spec values:

  • ESHUTDOWN
  • NBD_REP_ERR_SHUTDOWN
@Merovius Merovius added the beta Issues that should be fixed or closed as wontfix in v0 label Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta Issues that should be fixed or closed as wontfix in v0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Merovius