Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockSizeConstraints are not yet enforced by the server #1

Open
Merovius opened this issue Nov 19, 2018 · 0 comments
Open

BlockSizeConstraints are not yet enforced by the server #1

Merovius opened this issue Nov 19, 2018 · 0 comments
Labels
beta Issues that should be fixed or closed as wontfix in v0

Comments

@Merovius
Copy link
Owner

Eventually, the server should enforce block size constraints. We might return errors if the client does not negotiate block sizes, or alternatively do the chunking and aligning ourselves - either way, an nbd.Device should be able to rely on alignment guarantees when it specifies constraints.

Relevant spec values:

  • NBD_INFO_BLOCK_SIZE
  • NBD_REP_ERR_BLOCK_SIZE_REQD
@Merovius Merovius added the beta Issues that should be fixed or closed as wontfix in v0 label Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta Issues that should be fixed or closed as wontfix in v0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Merovius