Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more cell type #816

Open
Keith-CY opened this issue Jan 27, 2025 · 3 comments
Open

Add more cell type #816

Keith-CY opened this issue Jan 27, 2025 · 3 comments
Assignees
Labels

Comments

@Keith-CY
Copy link
Member

Is your feature request related to a problem? Please describe.
Output#0 in https://testnet.explorer.nervos.org/transaction/0x27ea4c221593930ae2de4a140ecd0e9707e22a41fe637f5205587cc6831b105e#0 and Output#0 in https://testnet.explorer.nervos.org/transaction/0xd251de6053d298766cd49ea80a163e0a4259807e254ed03e3cf98b174f786407 are fiber channels holding xudt and ckb, but they are not highlighted clearly.

Describe the solution you'd like

These cells can be marked primarily, e.g.

#0             address              [icon] Fiber                ckb | xudt amount

Kindly be noted that a cell can be marked as xudt and fiber channel. fiber channel is prior to xudt if only one is displayed because the attribute of xudt can be revealed by the xudt amount field

Additional context
Fiber Channel on Testnet

  {
    codeHashes: ['0x6c67887fe201ee0c7853f1682c0b77c0e6214044c156c7558269390a8afa6d7c'],
    txHashes: ['0x89af398edc7ed0054506b33349b031097d94378e11e77bf0690ee69d82623a43-0'],
    depType: 'code',
    hashType: 'type',
    tag: 'Fiber Channel',
  },

Meanwhile, the channel cells can be listed on the address page

Image

And

Cells holding source code can be marked as Deployment

#0           address               [icon] Deployment                   Script Name
@poor-defined poor-defined assigned rabbitz and unassigned poor-defined Feb 19, 2025
@poor-defined poor-defined moved this to 📌Planning in CKB Explorer Feb 19, 2025
@poor-defined poor-defined moved this from 📌Planning to 🏗 In Progress in CKB Explorer Feb 19, 2025
@poor-defined poor-defined moved this from 🏗 In Progress to 📌CurrentWeek in CKB Explorer Feb 19, 2025
@poor-defined poor-defined self-assigned this Feb 19, 2025
@Keith-CY
Copy link
Member Author

Kindly be noted that a cell can be marked as xudt and fiber channel. fiber channel is prior to xudt if only one is displayed because the attribute of xudt can be revealed by the xudt amount field

It's better to display xudt and fiber simultaneously, as I found there will be more cases of combined scripts.

Ref:
All renowned scripts can be found at https://explorer.nervos.org/scripts

@poor-defined
Copy link
Contributor

I split this issue into 2 PRD:

  • Support Fiber network on Address detail page and Transaction detail page , PRD ;
  • Mark Cell with source code in Address detail page and Transaction detail page , PRD

@Keith-CY @rabbitz cc @Kirl70

@Kirl70
Copy link

Kirl70 commented Feb 23, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📌CurrentWeek
Development

No branches or pull requests

4 participants