Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove properscoring dependency in MESMER-X #605

Open
veni-vidi-vici-dormivi opened this issue Jan 31, 2025 · 0 comments
Open

Remove properscoring dependency in MESMER-X #605

veni-vidi-vici-dormivi opened this issue Jan 31, 2025 · 0 comments
Assignees

Comments

@veni-vidi-vici-dormivi
Copy link
Collaborator

This is the only line in the MESMER Codebase that uses proper scoring. In favor of keeping the number of external dependencies small can we consider replacing this with something else? For example https://docs.scipy.org/doc/scipy/reference/generated/scipy.integrate.quad.html?

tmp_cprs.append(
ps.crps_quadrature(
x=self.data_targ[i],
cdf_or_dist=distrib,
xmin=-10 * np.abs(self.data_targ[i]),
xmax=10 * np.abs(self.data_targ[i]),
tol=1.0e-4,
)
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants