Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMR Change Vs Cumulative MMR Change #32

Open
kazzy2 opened this issue May 27, 2023 · 3 comments
Open

MMR Change Vs Cumulative MMR Change #32

kazzy2 opened this issue May 27, 2023 · 3 comments

Comments

@kazzy2
Copy link

kazzy2 commented May 27, 2023

previously using this plugin with the circle theme, the default was that the MMR at the top would be the cumulative MMR change for the gamemode (as I had stats set to track per gamemode).

After reinstalling it was performing MMR Change per match. When I edited the JSON file to replace with Cumulative MMR Change the rest of the stats change when I change gamemodes but the MMR Change is for for the whole session.

Is there a function to display how I had it when originally installed?

@Arubinu
Copy link
Collaborator

Arubinu commented May 27, 2023

I advise you to duplicate the Circle theme so as not to be affected by updates (which will replace the modified theme each time).

Then, if you put the mode in "GameMode", each of its parameters will change according to the mode you launch.
And the theme is already made to display the MMRCumulChange. If you want to find the base file, it is on this repository in bakkesmod > RocketStats > RocketStats_themes > Circle > config.json.

@kazzy2
Copy link
Author

kazzy2 commented May 28, 2023

This has not been the case for me recently. As described when I had the plugin previously installed the circle theme in its default config under the gamemode mode worked as I described that I want it to, however now in its default state it shows single game mmr change, with the modified cumulative mmr change config the mmr change is not differing between gamemodes and is for an overall session despite being setup in the gamemode mode. All other stats like streaks wins and losses are changing per game mode, just not delta mmr

Edit: Ive just switched to "session mode" and streak, wins and losses show was session but mmr shows per gamemode.
Very odd that only mmr change is reading the wrong mode format. Any idea on which section of the code to look at for this?

@Arubinu
Copy link
Collaborator

Arubinu commented May 28, 2023

To be checked, but it is likely that the MMRChange/MMRCumulChange is not independent per game mode (it is not saved data).

On the other hand, from memory, it was never a saved data.
So at no time should it work by game mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants