-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downloading the Chrome WebDriver fails with Chrome >=15 (OSOE-664) #302
Comments
Hi @Piedone, You can also consider Atata.WebDriverSetup library, which handles Chrome v115+ drivers and not only. |
Ah nice, I didn't know about that project, thanks for chiming in Yevgeniy. Do I understand correctly that this project has exactly the same goal as the above-mentioned WebDriverManager.Net and Selenium Manager? |
Basically, yes, but with few additions. |
Awesome, thanks! |
Not yet fully done, needs a NuGet release too. |
@DAud-IcI I’m getting such exceptions locally randomly which does seem to be due to the changes here, and might be the same exception from the CI build in disguise:
Also got this repeatedly:
While both of these go away on repeated runs, it seems that there's some flakiness in the driver creation (which results in repeated runs, slowing down test execution. I'm using VS Test Explorer, which might matter since at a quick glance over a couple of the recent OSOCE CI builds I haven't seen any flakiness. Perhaps we should run |
Could you give me more context? I couldn't reproduce this in VS2022, I've even tried running the whole Lombiq.Tests.UI.Samples multiple times with no such result. At any rate, I've added a lock around |
I get this randomly for 0, 1, or multiple tests after running them all with this button from VS: Or highlighting the UI test projects and clicking the button to its right. This runs tests in a project in parallel, but separate projects serially, so it's not like two UI tests projects can step on each others' feet. This is from the NuGetTest solution (where there's one UI test project anyway), where this happens just as it does in the root solution. I didn't change anything in the code but do note that this is my TestConfiguration.json (the one recommended in the docs), i.e. there's no retry to hide tests failing only randomly: {
"Lombiq_Tests_UI": {
"AgentIndex": 3,
"TimeoutConfiguration": {
"RetryTimeoutSeconds": 5,
"RetryIntervalMillisecondSeconds": 300,
"PageLoadTimeoutSeconds": 120
},
"OrchardCoreUITestExecutorConfiguration": {
"MaxRetryCount": 0,
"RetryIntervalSeconds": 0,
"MaxParallelTests": 0
},
"BrowserConfiguration": {
"Headless": true
}
}
} I've now run the tests for both solutions a few times. It correctly doesn't happen for the root solution, but still does for the NuGestTest one, as expected without new NuGet packages. |
Sounds like my fix does the job. I've applied it to the NuGet solution too. |
This is because WebDriverManager.Net didn't follow up with the URL of ChromeDriver packages having a different URL starting with v15: rosolko/WebDriverManager.Net#253 The linked issue also has potential solutions. The task here is to fix our issue, in the following ways:
dev
and out via NuGet ASAP, most possibly this one (here's some code that shows most possibly this in a wider context; we need to use it here). Publish a new NuGet release.Jira issue
The text was updated successfully, but these errors were encountered: