Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RichProgressBar visible for both light and dark theme by default #17118

Closed
tshu-w opened this issue Mar 17, 2023 · 4 comments · Fixed by #20260 · May be fixed by #18505 or #19239
Closed

Make RichProgressBar visible for both light and dark theme by default #17118

tshu-w opened this issue Mar 17, 2023 · 4 comments · Fixed by #20260 · May be fixed by #18505 or #19239
Labels
feature Is an improvement or enhancement good first issue Good for newcomers progress bar: rich
Milestone
future

Comments

@tshu-w
Copy link
Contributor

tshu-w commented Mar 17, 2023 •
edited
Loading

Description & Motivation

The RichProgressBar with default parameters is difficult to distinguish in the light theme. It is hoped that RichProgressBar will be visible by default in both light and dark themes without requiring users to modify the theme like #10833 (comment)

Screenshot 2023-03-17 at 12 46 29

Pitch

Try to use the first 16 standard colors combined with ansi styles in RichProgressBarTheme, which are usually defined by the terminal theme.

Alternatives

Not quite sure, welcome to provide suggestions.

Additional context

If the suggestion is feasible, I can submit a pull request.

cc @Borda
@tshu-w tshu-w added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Mar 17, 2023
@tshu-w tshu-w changed the title Make RICHPROGRESSBAR visible for both light and dark theme by default Make RichProgressBar visible for both light and dark theme by default Mar 17, 2023
@stale stale bot added the won't fix This will not be worked on label Apr 16, 2023
@Lightning-AI Lightning-AI deleted a comment from stale bot Apr 17, 2023
@stale stale bot removed the won't fix This will not be worked on label Apr 17, 2023
@Borda Borda added good first issue Good for newcomers won't fix This will not be worked on labels Apr 17, 2023
@stale stale bot removed the won't fix This will not be worked on label Apr 17, 2023
@Borda Borda added this to the future milestone Apr 17, 2023
@Lightning-AI Lightning-AI deleted a comment from tshu-w Apr 17, 2023
@Borda
Copy link
Member

Borda commented Apr 17, 2023

@tshu-w would you be interested in sending a PR? 😇

@tshu-w
Copy link
Contributor Author

tshu-w commented Apr 18, 2023

@Borda Of course, but it may not be very fast.

@ashikshafi08
Copy link

Hello,

@tshu-w are you still working on this? I'm planning to work on this, would love to have your input on this.

Thank you.

@tshu-w
Copy link
Contributor Author

tshu-w commented Apr 30, 2023

Hello, @ashikshafi08, I was interrupted by other things so I haven't started yet. If you are willing to work on it and submit a PR, that would be great. My initial idea is the one mentioned above.

@ashikshafi08 ashikshafi08 mentioned this issue Apr 30, 2023
Closed
7 tasks
@Tribhuvan0 Tribhuvan0 mentioned this issue Sep 8, 2023
Open
7 tasks
@awaelchli awaelchli added progress bar: rich and removed needs triage Waiting to be triaged by maintainers labels Sep 8, 2023
@manascb1344 manascb1344 mentioned this issue Jan 9, 2024
Open
5 tasks
@tshu-w tshu-w mentioned this issue Sep 7, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement good first issue Good for newcomers progress bar: rich
Projects
None yet
Milestone
future
4 participants
@awaelchli @Borda @tshu-w @ashikshafi08