Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove global variable 'myThreshold' #2

Closed
hartig opened this issue Mar 3, 2021 · 2 comments
Closed

remove global variable 'myThreshold' #2

hartig opened this issue Mar 3, 2021 · 2 comments
Assignees

Comments

@hartig
Copy link
Member

hartig commented Mar 3, 2021

@shahrzadkhayatbashi I see that you introduce a global variable called myThreshold in line 45 and then use that global variable in some of the helper functions. That's bad coding style. Please remove this global variable and, instead, pass the threshold as an additional parameter to the functions.

@shahrzadkhayatbashi
Copy link
Collaborator

I addressed the global variable issue by removing it and passing it to the calculate function.

@hartig
Copy link
Member Author

hartig commented Mar 8, 2021

The fix that addresses this issue is in commit e3f97c6

@hartig hartig closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants