Footer version numbers

[jSML4ThWwBID69YC]

How do you set the version numbers in the footer?

For example,
UI: v0.17.3 BE: 0.17.3

When I build Lemmy/Lemmy-UI, the version comes up as: BE: unknown version

Is this a compile time option?

[dessalines]

It comes from the docker build, and the git tag:

echo "pub const VERSION: &str = \"$(git describe --tag)\";" > "crates/utils/src/version.rs" \

[jSML4ThWwBID69YC]

Thank you! That sets the BE: version, but not the UI version. Is there a second item for the UI?

[SleeplessOne1917]

Only one version is displayed if the FE and BE versions are the same.

[jSML4ThWwBID69YC]

I just rebuilt Lemmy and Lemmy-ui at version 0.17.3. The UI string is still showing unknown version.

Looks like this
UI: unknown version BE: 0.17.3

Any ideas.

[jheidecker]

Just my two cents, but IMO, this is not a tag formatting issue. The version that gets displayed is statically set to "unknown version" (https://github.com/LemmyNet/lemmy-ui/blob/0.17.4/src/shared/version.ts) UNLESS you build with Docker (https://github.com/LemmyNet/lemmy-ui/blob/0.17.4/Dockerfile), in which case, it is set to the git tag. So the formatting issue may be true, but not when building UI without using docker. It will just be "unknown version" unless you change it explicitly before building, which then removes it entirely from being displayed IF the string is the same.

[SleeplessOne1917]

It seems the UI version should have a v at the front and the backend no v. E.g. v0.17.3. It must have been a mistake when making the tag.

[jSML4ThWwBID69YC]

It seems the UI version should have a v at the front and the backend no v. E.g. v0.17.3. It must have been a mistake when making the tag.

Ok. So it'll probably just work on the next release?

[SleeplessOne1917]

So it'll probably just work on the next release?

Provided a similar mistake doesn’t happen again, yes.

[jSML4ThWwBID69YC]

Provided a similar mistake doesn’t happen again, yes.

Thank you. I appreciate your help.

[verymilan]

hmm but if i just install with cargo (following the docs), i can't modify the source anymore to set a version...

edit: i am incorrect , still not very handy

[dessalines]

@SleeplessOne1917 we should make those a uniform 0.0.0 with no v, and then let the UI add the V if necessary.

Lets leave a lot of these smaller issues until after the http rework.