-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SnackBar 5XX message more descriptive #1532
Comments
Jerboa doesn't show full message in the Toast because Toast message their max length is arbitrary defined. It varies between Android version, OEM model, screen resolution, screen size, ... There is no well defined maximum message size. So we aim to be as brief as possible. Instead what we can do if it fails to load the feed is show the full error message in the feed. Another solution that is being worked on: The log Viewer which will also have full the message. Something else we can also do, use an heuristic to detect that an instance is in maintenance and display that in the Snackbar. Currently I believe the snackbar will just simply say, "Instance is experiencing internal issues"? @dessalines Does instance always return 503 and only for maintenance or does this vary between instance? |
Currently I believe the snackbar will just simply say, "Instance is
experiencing internal issues"?
Yes, I meant "snackbar" instead of "toast", my bad :P
Another solution that is being worked on: The log Viewer which will
also have full the message.
I think that for this type of message, shoving into the log isn't a good
idea, as it ought to be very clear to the user, and not tucked away
somewhere.
Displaying the message in the feed sounds like the best approach, as it
has more space to fit potentially larger messages and doesn't
automatically go away.
Something else we can also do, use an heuristic to detect that an
instance is in maintenance and display that in the Snackbar.
503 is defined as temporary status for when the server is overloaded or
under maintenece, so having a special handler for it sounds good to me.
@dessalines Does instance always return 503 and only for maintenance
or does this vary between instance?
As far as I know, it's up to the instance admins to configure that in
their web server (nginx, apache, caddy, etc).
|
That's correct, the only time I can see that we use a 503 in the backend, is during server startup, which shouldn't take more than a few seconds unless there's been an upgrade. Having these errors in the log viewer is the only real solution IMO. |
Pre-Flight checklist
Describe The Feature Request Below
The app should display the HTTP content returned by the server in case of an error. For example, the app currently displays a toast for 5xx codes, but it doesn't show the message, which makes it impossible to show Jerboa users there's a maintenance happening (503). The Thunder app does show it.
The text was updated successfully, but these errors were encountered: