Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MediaInfo support is not working as intended #842

Open
LeMyst opened this issue Mar 10, 2025 · 0 comments · May be fixed by #843
Open

fix: MediaInfo support is not working as intended #842

LeMyst opened this issue Mar 10, 2025 · 0 comments · May be fixed by #843
Assignees

Comments

@LeMyst
Copy link
Owner

LeMyst commented Mar 10, 2025

I found two regression in the MediaInfo support in WikibaseIntegrator:

During the splut between BaseEntity and MediaInfoEntity, some code migrated from one file to the other one, but was commented:
I think it's a mistake from my side:
af30069#diff-5506aaa6621db95681c0f1df605ad3eaed7de64934b5f038ebec3ba19fb7cbe0
This changes broke the "write" part of the MediaInfo support.

The other one mistake from me, was when adding support for the "props" field, allowing to support optional fields when getting entities, to speed up the process, and the reducing the bandwidth used:
85e8515#diff-5506aaa6621db95681c0f1df605ad3eaed7de64934b5f038ebec3ba19fb7cbe0
The issue is located line 146 of the mediainfo.py, where I check for the aliases field instead of the statements field.
This changes broke the "read" part of the MediaInfo support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant