Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Socialshare symbols are missing #9820

Open
rich20 opened this issue Feb 10, 2025 · 3 comments
Open

Some Socialshare symbols are missing #9820

rich20 opened this issue Feb 10, 2025 · 3 comments
Milestone

Comments

@rich20
Copy link
Member

rich20 commented Feb 10, 2025

To Reproduce
Enter the following profile information:

MySpace
Blogger
QQ
Qzone
Wechat
Odnoklassniki

Actual result
Nothing is displayed in the profile

@rich20 rich20 added this to the 6.4 milestone Feb 10, 2025
@Pinkeltje
Copy link
Contributor

Pinkeltje commented Feb 11, 2025

Is it blogger or blogspot?
Most icons exist but are not inserted now.
Blogger=
<i class="fa-brands fa-blogger"></i>
Can't find myspace and I am apparently not the only one
FortAwesome/Font-Awesome#831
qq =
<i class="fa-brands fa-qq"></i>
Can't find Qzone (Same as myspace)
FortAwesome/Font-Awesome#3993
Wechat =
<i class="fa-brands fa-weixin"></i>
Odnoklassniki =
<i class="fa-brands fa-square-odnoklassniki"></i>

Can make pull request for exising fontawesome icons, but might be a good idea to first decide what to do with Myspace and Qzone. Keep them and add random icon, or delete entirely?

When checking, found errors in language files as well:

Image

@Pinkeltje
Copy link
Contributor

Lines 828 to 831 com_kunena_templates.ini should be changed to

COM_KUNENA_MYPROFILE_BLOGSPOT = "Blogger"
COM_KUNENA_MYPROFILE_BLOGSPOT_DESC = "This is your Blogger username."
COM_KUNENA_MYPROFILE_BLUESKY_APP = "BlueSky"
COM_KUNENA_MYPROFILE_BLUESKY_APP_DESC = "This is your BlueSkyApp username."

There are duplicate language strings in this file as well Bluesky in lines mentionned above and in lines 856 and 857.

@Pinkeltje
Copy link
Contributor

Just tested with Nightly Build. Result: Entries that have no FA icon are not rendered in the view. Makes sense as there is nothing to see when there is no icon.
So we have to decide what to do

Can make pull request for exising fontawesome icons, but might be a good idea to first decide what to do with Myspace and Qzone. Keep them and add random icon, or delete entirely?

Comparison rendered html and db entries in attachment
social icons.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants