[GeoMechanicsApplication] Unit tests for TransientPwElement #13012
+861
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfaasse
reviewed
Jan 17, 2025
| @@ -19,7 +19,6 @@ | |||
| #include "custom_elements/U_Pw_small_strain_element.hpp" | |||
| #include "custom_utilities/element_utilities.hpp" | |||
| #include "custom_utilities/stress_strain_utilities.h" | |||
| #include "geo_mechanics_application_variables.h" | |||
There was a problem hiding this comment.
Nice catch! Removing these when redundant will speed up compilation times (especially large headers like this one)
Comment on lines
190
to
192
| for (auto p_dof : degrees_of_freedom) { | ||
| KRATOS_EXPECT_EQ(p_dof->GetVariable(), WATER_PRESSURE); | ||
| } |
There was a problem hiding this comment.
I think we could use an algorithm here (might be syntax errors here, but something like this):
Suggested change
| for (auto p_dof : degrees_of_freedom) { | |
| KRATOS_EXPECT_EQ(p_dof->GetVariable(), WATER_PRESSURE); | |
| } | |
| KRATOS_EXPECT_TRUE(std::all_of(degrees_of_freedom.begin(), degrees_of_freedom.end(), [](auto pdof){return p_dof->GetVariable() == WATER_PRESSURE;}); |
Comment on lines
431
to
433
| for (const auto& retention_law : r_retention_law_vector) { | ||
| KRATOS_EXPECT_NE(dynamic_cast<SaturatedLaw*>(retention_law.get()), nullptr); | ||
| } |
There was a problem hiding this comment.
Similar to my other comment, we should be able to use std::none_of here (KRATOS_EXPECT_TRUE(std::none_of... etc)
Comment on lines
449
to
451
| for (auto& node : p_element->GetGeometry()) { | ||
| KRATOS_EXPECT_EQ(node.FastGetSolutionStepValue(HYDRAULIC_DISCHARGE), 0.0); | ||
| } |
There was a problem hiding this comment.
We can use a std::all_of here (and also in some other places in the next tests 👍 )
markelov208
commented
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
A brief description of the PR.
Unit tests have been created for the following TransientPwElement functions
Two unit tests (2D and 3D elements) call CalculateLocalSystem that calls
An extra unit test is created for functions that are empty or return zero values:
18. CalculateMassMatrix
19. CalculateDampingMatrix
20. GetValuesVector
21. GetFirstDerivativesVector
22. GetSecondDerivativesVector
23. InitializeNonLinearIteration
24. FinalizeNonLinearIteration