Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core][Geometry] The BoundingBox method in geometry uses TPointType, instead of Point, forcing to use Node in most geometries #12991

Open
loumalouomega opened this issue Jan 9, 2025 · 0 comments
Open

[Core][Geometry] The BoundingBox method in geometry uses TPointType, instead of Point, forcing to use Node in most geometries #12991

loumalouomega opened this issue Jan 9, 2025 · 0 comments
Labels
Discussion Inconsistent Kratos Core

Comments

@loumalouomega
Copy link
Member

loumalouomega commented Jan 9, 2025 •
edited
Loading

Kratos/kratos/geometries/geometry.h

Line 1505 in 7da0f26

TPointType& rLowPoint,

The BoundingBox method in geometry uses TPointType, instead of Point, forcing to use Node in most geometries, I would replace it using the Point for sake of generality (also nodes are much heavier than Points)

FYI @KratosMultiphysics/technical-committee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Inconsistent Kratos Core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loumalouomega