Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Double down on only generation, not rewriting HTML files. #24

Open
5 tasks
KonnorRogers opened this issue Oct 21, 2020 · 0 comments
Open
5 tasks
Labels
enhancement New feature or request

Comments

@KonnorRogers
Copy link
Owner

KonnorRogers commented Oct 21, 2020

Basically I don't like the implementation of rewriting the HTML. I want the user to have to implement a way to read from the manifest.json and make it clear that this will not retain their source files. This will make this library easier to maintain and hopefully improve performance.

  • - Remove emitHtmlFiles option
  • - Remove preserveSourceFiles option
  • - Add a testing function to read from Manifest.
  • - Make It obvious that all output files will be removed. If it's not imported by an entrypoint, it will be removed.
  • - Update README of new changes. Ensure to include the value of outputOptions.dir will be where the directory that gets replaced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant