building against system openssl and openresty

[kranurag7]

Hello there,

I'm trying to build kong that leverages system openssl and system openresty, I've considered patching *.bazel files but kong build system involves a lot of bazel files and things are nested so I'm failing there.

Below is the patch, I'm trying out as of now.

diff

diff --git a/BUILD.bazel b/BUILD.bazel
index 4602b77e0..6dde28d00 100644
--- a/BUILD.bazel
+++ b/BUILD.bazel
@@ -196,7 +196,7 @@ string_flag(
     build_setting_default = "dynamic",
     values = [
         "dynamic",
-        "static",
+        # "static",
     ],
 )
 
diff --git a/build/BUILD.bazel b/build/BUILD.bazel
index b83f4f487..5ac5c5b49 100644
--- a/build/BUILD.bazel
+++ b/build/BUILD.bazel
@@ -10,7 +10,7 @@ exports_files([
 # C libraries
 
 clib_deps = [
-    "@openssl",
+    # "@openssl",
     "@libexpat",
     "@snappy",
     "@ada",
@@ -47,7 +47,7 @@ kong_rules_group(
 kong_rules_group(
     name = "cacheable-targets",
     propagates = [
-        "@openssl",
+        # "@openssl",
         "@libexpat",
         "@atc_router",
         "@simdjson_ffi",
@@ -61,21 +61,21 @@ kong_rules_group(
 
 # OpenResty
 
-kong_install(
-    name = "install-openresty-luajit",
-    src = "@openresty//:luajit",
-    prefix = "openresty/luajit",
-)
-
-kong_install(
-    name = "install-openresty",
-    src = "@openresty",
-    prefix = "openresty",
-    deps = [
-        ":install-openresty-luajit",
-        ":install-openssl",
-    ],
-)
+# kong_install(
+#     name = "install-openresty-luajit",
+#     src = "@openresty//:luajit",
+#     prefix = "openresty/luajit",
+# )
+
+# kong_install(
+#     name = "install-openresty",
+#     src = "@openresty",
+#     prefix = "openresty",
+#     deps = [
+#         # ":install-openresty-luajit",
+#         # ":install-openssl",
+#     ],
+# )
 
 # Use this target when developing with nginx modules and want to
 # avoid rebuilding a clean OpenResty every time.
@@ -241,7 +241,7 @@ kong_rules_group(
         ":install-clibs",
         ":install-lualibs",
         ":install-wasmx",
-        ":install-openresty",
+        # ":install-openresty",
         ":install-static-assets",
         ":install-tools",
     ],
diff --git a/build/luarocks/BUILD.bazel b/build/luarocks/BUILD.bazel
index 79168c44d..14d9c6d09 100644
--- a/build/luarocks/BUILD.bazel
+++ b/build/luarocks/BUILD.bazel
@@ -13,6 +13,9 @@ exports_files(
 
 kong_rules_group(
     name = "luarocks",
+    # env = {
+    #     "OPENSSL_INCDIR" : "/usr",
+    # },
     propagates = [
         "@luarocks//:luarocks_make",
         "@luarocks//:luarocks_target",
diff --git a/build/luarocks/BUILD.luarocks.bazel b/build/luarocks/BUILD.luarocks.bazel
index b23ad9609..50006bce0 100644
--- a/build/luarocks/BUILD.luarocks.bazel
+++ b/build/luarocks/BUILD.luarocks.bazel
@@ -40,7 +40,7 @@ kong_template_genrule(
     name = "luarocks_exec",
     srcs = [
         "@libexpat",
-        "@openssl",
+        # "@openssl",
     ] + select({
         "@kong//:any-cross": ["@cross_deps_libyaml//:libyaml"],
         "//conditions:default": [
diff --git a/build/luarocks/templates/luarocks_exec.sh b/build/luarocks/templates/luarocks_exec.sh
index 10515f8f0..1c148e9f3 100644
--- a/build/luarocks/templates/luarocks_exec.sh
+++ b/build/luarocks/templates/luarocks_exec.sh
@@ -3,7 +3,7 @@
 # template variables starts
 libexpat_path="{{@@libexpat//:libexpat}}"
 libxml2_path="invalid"
-openssl_path="{{@@openssl//:openssl}}"
+# openssl_path="{{@@openssl//:openssl}}"
 luarocks_host_path="{{@@luarocks//:luarocks_host}}"
 luajit_path="{{@@openresty//:luajit}}"
 kongrocks_path="invalid"
diff --git a/build/openresty/BUILD.openresty.bazel b/build/openresty/BUILD.openresty.bazel
index 81ad1724f..c20c41fd9 100644
--- a/build/openresty/BUILD.openresty.bazel
+++ b/build/openresty/BUILD.openresty.bazel
@@ -326,7 +326,7 @@ configure_make(
     visibility = ["//visibility:public"],
     deps = [
         "@openresty//:luajit",
-        "@openssl",
+        # "@openssl",
         "@pcre",
     ] + select({
         "@kong//:any-cross": [
diff --git a/build/openresty/ada/BUILD.bazel b/build/openresty/ada/BUILD.bazel
index 9a157965e..2d6c76c4c 100644
--- a/build/openresty/ada/BUILD.bazel
+++ b/build/openresty/ada/BUILD.bazel
@@ -8,7 +8,7 @@ cc_library(
     copts = [
         "-std=c++17",
     ],
-    linkstatic = True,
+    linkstatic = False,
 )
 
 cc_shared_library(
diff --git a/build/openresty/openssl/BUILD.bazel b/build/openresty/openssl/BUILD.bazel
index 5970c67b2..3a475c024 100644
--- a/build/openresty/openssl/BUILD.bazel
+++ b/build/openresty/openssl/BUILD.bazel
@@ -1,5 +1,5 @@
-load("@kong//build/openresty/openssl:openssl.bzl", "build_openssl")
+# load("@kong//build/openresty/openssl:openssl.bzl", "build_openssl")
 
-build_openssl(
-    name = "openssl",
-)
+# build_openssl(
+#     name = "openssl",
+# )
diff --git a/build/openresty/snappy/BUILD.bazel b/build/openresty/snappy/BUILD.bazel
index 499e4fb29..1a5df9225 100644
--- a/build/openresty/snappy/BUILD.bazel
+++ b/build/openresty/snappy/BUILD.bazel
@@ -77,7 +77,7 @@ cc_library(
             "-Wno-sign-compare",
         ],
     }),
-    linkstatic = True,
+    linkstatic = False,
     deps = [
         ":config",
         ":snappy-stubs-internal",
diff --git a/build/repositories.bzl b/build/repositories.bzl
index 4004b32f7..7a0093014 100644
--- a/build/repositories.bzl
+++ b/build/repositories.bzl
@@ -50,12 +50,9 @@ def github_cli_repositories():
         )
 
 def kong_github_repositories():
-    maybe(
-        github_release,
+    http_archive(
         name = "kong_admin_gui",
-        repo = "kong/kong-manager",
-        tag = KONG_VAR["KONG_MANAGER"],
-        pattern = "release.tar.gz",
+        url = "https://github.com/Kong/kong-manager/releases/download/nightly/release.tar.gz",
         build_file_content = _DIST_BUILD_FILE_CONTENT,
     )
 

so far after trying out this patch, I'm running into the following error.

(06:16:47) ERROR: /home/user/.cache/bazel/_bazel_user/b0a3c4100dd691c6efebdbf3258df3bc/external/luarocks/BUILD.bazel:67:22: Luarocks: Install Kong rocks dependencies failed
: (Exit 1): bash failed: error executing Action command (from target @@luarocks//:luarocks_make)
  (cd /home/user/.cache/bazel/_bazel_user/b0a3c4100dd691c6efebdbf3258df3bc/execroot/_main && \
  exec env - \
  /bin/bash -c 'bazel-out/k8-opt/bin/external/luarocks/luarocks_make.rendered.sh bazel-out/k8-opt/bin/external/luarocks/luarocks_make.log')
# Configuration: 30ce272573d38bcfe24ea670125bfd05f1ec2be4a953128046b3bbdfea844452
# Execution platform: @@platforms//host:host

Error: Failed installing dependency: https://luarocks.org/luasec-1.3.2-1.src.rock - Could not find header file for OPENSSL
  No file openssl/ssl.h in /home/user/.cache/bazel/_bazel_user/b0a3c4100dd691c6efebdbf3258df3bc/execroot/_main/include
You may have to install OPENSSL in your system and/or pass OPENSSL_DIR or OPENSSL_INCDIR to the luarocks command.
Example: luarocks install luasec OPENSSL_DIR=/usr/local
Target //build:kong failed to build

apart from this, I've have also tried running these make commands after patching.

make install-dev-rocks
make build-release

I was doing this because Makefile seems to set OPENSSL_DIR via OPENSSL_DIR ?= /usr but that also didn't worked.

Is there an easy way to build against system openssl that I'm missing here? I searched issues/discussions but was not able to find one?

[fffonion]

Using system openresty won't work as Kong applies several patches to openresty. Apart from that, using system openssl should work as long as the
openssl library and headers are installed in well-known path.