Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] ImageSlice Prop3D: force consistent render pass despite transparency #3126

Closed
PaulHax opened this issue Sep 27, 2024 · 2 comments
Closed
Labels
module: rendering General rendering issues released Automated label type: feature request 💡 Desired capabilities / enhancements

Comments

@PaulHax
Copy link
Collaborator

PaulHax commented Sep 27, 2024

Feature Request

Motivation

When the prop's transparency crosses from .999 to 1, it gets slotted in the Opaque render pass and can change its render order: https://github.com/Kitware/vtk-js/blob/master/Sources/Rendering/Core/ImageSlice/index.js#L24-L26

When multiple slices are layered changing the tranparency can inavertently change how they are blended.

Motivation and Detailed Description

Approach?

Add imageSlice.setForceTransparent(true) function to ImageSlice Prop3D? Or add it to the Prop3D "class." Or make ImageSlice extend Actor3D?

@PaulHax PaulHax added type: feature request 💡 Desired capabilities / enhancements module: rendering General rendering issues labels Sep 27, 2024
PaulHax added a commit to PaulHax/vtk-js that referenced this issue Sep 27, 2024
To maintain consistent render effect with stacked image slices
no matter the opacity of the slices.

closes Kitware#3126
github-merge-queue bot pushed a commit that referenced this issue Sep 30, 2024
To maintain consistent render effect with stacked image slices
no matter the opacity of the slices.

closes #3126
Copy link

🎉 This issue has been resolved in version 32.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Sep 30, 2024
@PaulHax
Copy link
Collaborator Author

PaulHax commented Sep 30, 2024

completed with #3128

@PaulHax PaulHax closed this as completed Sep 30, 2024
bruyeret pushed a commit to bruyeret/vtk-js that referenced this issue Oct 1, 2024
To maintain consistent render effect with stacked image slices
no matter the opacity of the slices.

closes Kitware#3126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: rendering General rendering issues released Automated label type: feature request 💡 Desired capabilities / enhancements
Projects
None yet
Development

No branches or pull requests

1 participant