FEI-4957.1: Remove file extensions from imports/requires (#522)

## Summary:
TypeScript doesn't work with file extensions in imports.  This PR removes all .js file imports and requires.

I use find'n'replace with `.js";` and `.js");`.  This was imprecise and require a bunch of manual fixes.  In the future I will try using eslint's auto-fixing and if that doesn't work I'll use regex find and replaces to be more precise.

Issue: FEI-4957

## Test plan:
- yarn lint
- yarn test

Author: kevinbarabash

Reviewers: jeresig, kevinbarabash, somewhatabstract

Required Reviewers:

Approved By: jeresig, somewhatabstract

Checks: ✅ codecov/project, ✅ Test (macos-latest, 16.x), ✅ Lint, flow, and coverage check (ubuntu-latest, 16.x), ⏭  gerald, ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ✅ Test (macos-latest, 16.x), ✅ CodeQL, ✅ Lint, flow, and coverage check (ubuntu-latest, 16.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ✅ gerald, ✅ Analyze (javascript), ⏭  dependabot

Pull Request URL: #522

Author: kevinbarabash

.changeset/olive-humans-remain.md

@@ -74,7 +74,7 @@ module.exports = {
         "import/no-named-default": "error",
         "import/extensions": [
             "error",
-            "always",
+            "never",
             {
                 ignorePackages: true,
             },

.eslintrc.js

@@ -13,7 +13,6 @@ module.use_strict=true
 
 [lints]
 deprecated-type=error
-deprecated-utility=error
 sketchy-null=error
 sketchy-number=error
 unclear-type=error

.flowconfig

@@ -1 +1 @@
-module.exports = require("./packages/eslint-config-khan/.prettierrc.js");
+module.exports = require("./packages/eslint-config-khan/.prettierrc");

.prettierrc.js

@@ -4,4 +4,4 @@
  * Jest looks for the babel config in the cwd of the project and as such we
  * need a file to tell it where the config really lies or it would use it.
  */
-module.exports = require("./build-settings/babel.config.js");
+module.exports = require("./build-settings/babel.config");

babel.config.js

@@ -1,6 +1,6 @@
 /* eslint-disable import/no-commonjs */
-const createBabelPresets = require("./create-babel-presets.js");
-const createBabelPlugins = require("./create-babel-plugins.js");
+const createBabelPresets = require("./create-babel-presets");
+const createBabelPlugins = require("./create-babel-plugins");
 
 // This config is used for Jest testing here in this repository, only.
 module.exports = {

build-settings/babel.config.js

@@ -11,8 +11,8 @@ import filesize from "rollup-plugin-filesize";
 import {preserveShebangs} from "rollup-plugin-preserve-shebangs";
 import rollupExecutable from "rollup-plugin-executable-output";
 
-const createBabelPresets = require("./create-babel-presets.js");
-const createBabelPlugins = require("./create-babel-plugins.js");
+const createBabelPresets = require("./create-babel-presets");
+const createBabelPlugins = require("./create-babel-plugins");
 
 /**
  * We support the following config args with this rollup configuration:

build-settings/rollup.config.js

@@ -1,6 +1,6 @@
 /* eslint-disable import/no-commonjs */
 const babelJest = require("babel-jest").default;
 
-const babelConfig = require("../../build-settings/babel.config.js");
+const babelConfig = require("../../build-settings/babel.config");
 
 module.exports = babelJest.createTransformer(babelConfig);

config/jest/test.transform.js

@@ -1,2 +1,2 @@
 /* eslint-disable import/no-commonjs */
-module.exports = require("./config/jest/test.config.js");
+module.exports = require("./config/jest/test.config");

jest.config.js

@@ -107,7 +107,7 @@ module.exports = {
         /**
          * prettier rules
          */
-        "prettier/prettier": ["error", require("./.prettierrc.js")],
+        "prettier/prettier": ["error", require("./.prettierrc")],
 
         /**
          * react rules

packages/eslint-config-khan/index.js

@@ -1,5 +1,5 @@
 // @flow
-import {buildCausedByMessage} from "../build-caused-by-message.js";
+import {buildCausedByMessage} from "../build-caused-by-message";
 
 describe("#buildCausedByMessage", () => {
     it("should combine the strings into a 'caused by' message", () => {

packages/wonder-stuff-core/src/__tests__/build-caused-by-message.test.js

@@ -1,5 +1,5 @@
 // @flow
-import {cloneMetadata} from "../clone-metadata.js";
+import {cloneMetadata} from "../clone-metadata";
 
 describe("#cloneMetadata", () => {
     it.each([undefined, null])(

packages/wonder-stuff-core/src/__tests__/clone-metadata.test.js

@@ -1,5 +1,5 @@
 // @flow
-import {clone} from "../clone.js";
+import {clone} from "../clone";
 
 describe("#clone", () => {
     it.each([undefined, null])(

packages/wonder-stuff-core/src/__tests__/clone.test.js

@@ -1,5 +1,5 @@
 // @flow
-import {entries} from "../entries.js";
+import {entries} from "../entries";
 
 {
     // should type returned array element as tuples of keys as string subtype

packages/wonder-stuff-core/src/__tests__/entries.flowtest.js

@@ -1,5 +1,5 @@
 // @flow
-import {entries} from "../entries.js";
+import {entries} from "../entries";
 
 describe("#entries", () => {
     it("should call Object.entries with the given object", () => {

packages/wonder-stuff-core/src/__tests__/entries.test.js

@@ -1,8 +1,8 @@
 // @flow
-import * as BuildCausedByMessage from "../build-caused-by-message.js";
-import {ErrorInfo} from "../error-info.js";
+import * as BuildCausedByMessage from "../build-caused-by-message";
+import {ErrorInfo} from "../error-info";
 
-jest.mock("../build-caused-by-message.js");
+jest.mock("../build-caused-by-message");
 
 describe("ErrorInfo", () => {
     const NODE_ENV = process.env.NODE_ENV;

packages/wonder-stuff-core/src/__tests__/error-info.test.js

@@ -1,8 +1,8 @@
 // @flow
-import {KindError} from "../kind-error.js";
-import {errorsFromError, Order} from "../errors-from-error.js";
+import {KindError} from "../kind-error";
+import {errorsFromError, Order} from "../errors-from-error";
 
-import type {Options as KindErrorOptions} from "../kind-error.js";
+import type {Options as KindErrorOptions} from "../kind-error";
 
 describe("#errorsFromError", () => {
     it.each([null, undefined, "NOT_A_GOOD_VALUE", 42])(

packages/wonder-stuff-core/src/__tests__/errors-from-error.test.js

@@ -1,5 +1,5 @@
 // @flow
-import {Errors} from "../errors.js";
+import {Errors} from "../errors";
 
 describe("Errors", () => {
     it("should be frozen", () => {

packages/wonder-stuff-core/src/__tests__/errors.test.js

@@ -1,7 +1,7 @@
 // @flow
-import {Errors} from "../errors.js";
-import {getKindFromError} from "../get-kind-from-error.js";
-import {KindError} from "../kind-error.js";
+import {Errors} from "../errors";
+import {getKindFromError} from "../get-kind-from-error";
+import {KindError} from "../kind-error";
 
 describe("#getKindFromError", () => {
     it.each([null, undefined, new Error("test")])(

packages/wonder-stuff-core/src/__tests__/get-kind-from-error.test.js

@@ -1,6 +1,6 @@
 // @flow
-import {getOriginalStackFromError} from "../get-original-stack-from-error.js";
-import {KindError} from "../kind-error.js";
+import {getOriginalStackFromError} from "../get-original-stack-from-error";
+import {KindError} from "../kind-error";
 
 describe("#getOriginalStackFromError", () => {
     it("should return the stack of the error for a non-KindError value", () => {

packages/wonder-stuff-core/src/__tests__/get-original-stack-from-error.test.js

@@ -1,5 +1,5 @@
 // @flow
-import {keys} from "../keys.js";
+import {keys} from "../keys";
 
 {
     // should type returned array element as subtype of string

packages/wonder-stuff-core/src/__tests__/keys.flowtest.js

@@ -1,5 +1,5 @@
 // @flow
-import {keys} from "../keys.js";
+import {keys} from "../keys";
 
 describe("#keys", () => {
     it("should call Object.keys with the given object", () => {

packages/wonder-stuff-core/src/__tests__/keys.test.js

@@ -1,8 +1,8 @@
 // @flow
-import * as CloneMetadata from "../clone-metadata.js";
-import {ErrorInfo} from "../error-info.js";
-import {Errors} from "../errors.js";
-import {KindError} from "../kind-error.js";
+import * as CloneMetadata from "../clone-metadata";
+import {ErrorInfo} from "../error-info";
+import {Errors} from "../errors";
+import {KindError} from "../kind-error";
 
 describe("KindError", () => {
     const NODE_ENV = process.env.NODE_ENV;

packages/wonder-stuff-core/src/__tests__/kind-error.test.js

@@ -1,5 +1,5 @@
 // @flow
-import {safeStringify} from "../safe-stringify.js";
+import {safeStringify} from "../safe-stringify";
 
 describe("#safeStringify", () => {
     describe("without options or default value argument", () => {

packages/wonder-stuff-core/src/__tests__/safe-stringify.test.js

@@ -1,5 +1,5 @@
 // @flow
-import {truncateMiddle} from "../truncate-middle.js";
+import {truncateMiddle} from "../truncate-middle";
 
 describe("#truncateMiddle", () => {
     it.each(["", "ABCDE", "ABCDEFGH"])(

packages/wonder-stuff-core/src/__tests__/truncate-middle.test.js

@@ -1,5 +1,5 @@
 // @flow
-import {values} from "../values.js";
+import {values} from "../values";
 
 {
     // should type returned array element with union of value types of passed object

packages/wonder-stuff-core/src/__tests__/values.flowtest.js

@@ -1,5 +1,5 @@
 // @flow
-import {values} from "../values.js";
+import {values} from "../values";
 
 describe("#values", () => {
     it("should call Object.values with the given object", () => {

packages/wonder-stuff-core/src/__tests__/values.test.js

@@ -1,6 +1,6 @@
 // @flow
-import {clone} from "./clone.js";
-import type {Metadata} from "./types.js";
+import {clone} from "./clone";
+import type {Metadata} from "./types";
 
 /**
  * Clone the given metadata.

packages/wonder-stuff-core/src/clone-metadata.js

@@ -1,5 +1,5 @@
 // @flow
-import {buildCausedByMessage} from "./build-caused-by-message.js";
+import {buildCausedByMessage} from "./build-caused-by-message";
 
 /**
  * Information about an error.

packages/wonder-stuff-core/src/error-info.js

@@ -1,6 +1,6 @@
 // @flow
-import {KindError} from "./kind-error.js";
-import {Errors} from "./errors.js";
+import {KindError} from "./kind-error";
+import {Errors} from "./errors";
 
 export const Order = Object.freeze({
     ConsequenceFirst: "consequence-first",

packages/wonder-stuff-core/src/errors-from-error.js

@@ -1,6 +1,6 @@
 // @flow
-import {KindError} from "./kind-error.js";
-import {Errors} from "./errors.js";
+import {KindError} from "./kind-error";
+import {Errors} from "./errors";
 
 /**
  * Get the kind for the given error.

packages/wonder-stuff-core/src/get-kind-from-error.js

@@ -1,5 +1,5 @@
 // @flow
-import {KindError} from "./kind-error.js";
+import {KindError} from "./kind-error";
 
 /**
  * Get the original stack trace for the given error.

packages/wonder-stuff-core/src/get-original-stack-from-error.js

@@ -1,14 +1,14 @@
 // @flow
-export {clone} from "./clone.js";
-export {entries} from "./entries.js";
-export {keys} from "./keys.js";
-export {values} from "./values.js";
-export {Errors} from "./errors.js";
-export {errorsFromError, Order} from "./errors-from-error.js";
-export {getKindFromError} from "./get-kind-from-error.js";
-export {getOriginalStackFromError} from "./get-original-stack-from-error.js";
-export {KindError} from "./kind-error.js";
-export {safeStringify} from "./safe-stringify.js";
-export {truncateMiddle} from "./truncate-middle.js";
+export {clone} from "./clone";
+export {entries} from "./entries";
+export {keys} from "./keys";
+export {values} from "./values";
+export {Errors} from "./errors";
+export {errorsFromError, Order} from "./errors-from-error";
+export {getKindFromError} from "./get-kind-from-error";
+export {getOriginalStackFromError} from "./get-original-stack-from-error";
+export {KindError} from "./kind-error";
+export {safeStringify} from "./safe-stringify";
+export {truncateMiddle} from "./truncate-middle";
 
-export type {Metadata} from "./types.js";
+export type {Metadata} from "./types";

packages/wonder-stuff-core/src/index.js

@@ -1,9 +1,9 @@
 // @flow
-import {Errors} from "./errors.js";
-import {ErrorInfo} from "./error-info.js";
-import {cloneMetadata} from "./clone-metadata.js";
+import {Errors} from "./errors";
+import {ErrorInfo} from "./error-info";
+import {cloneMetadata} from "./clone-metadata";
 
-import type {Metadata} from "./types.js";
+import type {Metadata} from "./types";
 
 /**
  * Options for constructing a `KindError`.

packages/wonder-stuff-core/src/kind-error.js

@@ -10,7 +10,7 @@
  *   yarn all-i18n-strings file.js
  *   yarn all-i18n-strings "src/*.js"
  */
-import {getFilesToExtractFrom, getPoItemMap} from "../utils/pofile-utils.js";
+import {getFilesToExtractFrom, getPoItemMap} from "../utils/pofile-utils";
 
 // Get the files that we want to process.
 const files = getFilesToExtractFrom(process.argv.slice(2));

packages/wonder-stuff-i18n/src/bin/all-i18n-strings.js

@@ -19,7 +19,7 @@
 import {
     getFilesToExtractFrom,
     getPOTFileStringFromFiles,
-} from "../utils/pofile-utils.js";
+} from "../utils/pofile-utils";
 
 // Get the files that we want to process.
 const files = getFilesToExtractFrom(process.argv.slice(2));

packages/wonder-stuff-i18n/src/bin/gen-potfile.js

@@ -1,17 +1,17 @@
 // @flow
 /* istanbul ignore file */
-export {default as I18nPlugin} from "./plugins/i18n-plugin.js";
-export {extractStrings} from "./utils/extract-i18n.js";
+export {default as I18nPlugin} from "./plugins/i18n-plugin";
+export {extractStrings} from "./utils/extract-i18n";
 export {
     getFilesToExtractFrom,
     getPOTFileStringFromFiles,
-} from "./utils/pofile-utils.js";
+} from "./utils/pofile-utils";
 export {
     getIgnoreGlobs,
     getI18nStringsFromString,
     translateString,
-} from "./utils/i18n-utils.js";
-export {getEmojiForLocale} from "./utils/emoji-for-locale.js";
+} from "./utils/i18n-utils";
+export {getEmojiForLocale} from "./utils/emoji-for-locale";
 
-export type {ExtractedString} from "./utils/extract-i18n.js";
-export type {TranslatedLocaleStrings} from "./utils/i18n-utils.js";
+export type {ExtractedString} from "./utils/extract-i18n";
+export type {TranslatedLocaleStrings} from "./utils/i18n-utils";

packages/wonder-stuff-i18n/src/index.js

@@ -1,8 +1,8 @@
 // @flow
-import I18nPlugin from "../i18n-plugin.js";
+import I18nPlugin from "../i18n-plugin";
 
-import type {TranslatedLocaleStrings} from "../../utils/i18n-utils.js";
-import type {TranslatedStrings, Assets} from "../i18n-plugin.js";
+import type {TranslatedLocaleStrings} from "../../utils/i18n-utils";
+import type {TranslatedStrings, Assets} from "../i18n-plugin";
 
 type ResolvedAssets = {|
     [string]: ResolvedAsset,

packages/wonder-stuff-i18n/src/plugins/__tests__/i18n-plugin.test.js

@@ -20,15 +20,15 @@
 import path from "path";
 import {eachLimit} from "async";
 
-import * as I18nUtils from "../utils/i18n-utils.js";
+import * as I18nUtils from "../utils/i18n-utils";
 import {
     hashFileContents,
     extractHashFromFileName,
     localizeFile,
-} from "../utils/localize-file.js";
-import {getEmojiForLocale} from "../utils/emoji-for-locale.js";
+} from "../utils/localize-file";
+import {getEmojiForLocale} from "../utils/emoji-for-locale";
 
-import type {TranslatedLocaleStrings} from "../utils/i18n-utils.js";
+import type {TranslatedLocaleStrings} from "../utils/i18n-utils";
 
 /**
  * Add a new asset to the Webpack compilation assets.

packages/wonder-stuff-i18n/src/plugins/i18n-plugin.js

@@ -1,5 +1,5 @@
 // @flow
-import {getEmojiForLocale} from "../emoji-for-locale.js";
+import {getEmojiForLocale} from "../emoji-for-locale";
 
 describe("getEmojiForLocale", () => {
     it("returns an emoji for boxes", () => {

packages/wonder-stuff-i18n/src/utils/__tests__/emoji-for-locale.test.js

@@ -1,5 +1,5 @@
 // @flow
-import {extractStrings} from "../extract-i18n.js";
+import {extractStrings} from "../extract-i18n";
 
 const TEST_FILE = `
 const explanation = "I am a happy javascript file!";

packages/wonder-stuff-i18n/src/utils/__tests__/extract-i18n.test.js

@@ -5,7 +5,7 @@ import {
     getIgnoreGlobs,
     getI18nStringsFromString,
     translateString,
-} from "../i18n-utils.js";
+} from "../i18n-utils";
 
 jest.mock("ancesdir");
 

packages/wonder-stuff-i18n/src/utils/__tests__/i18n-utils.test.js

@@ -4,7 +4,7 @@ import {
     localizeString,
     localizeFile,
     hashFileContents,
-} from "../localize-file.js";
+} from "../localize-file";
 
 describe("hashFileContents", () => {
     it("produces a 20-char hash of a string", () => {