Deflowify wonder-stuff (#1001)

## Summary:
We're finished the TypeScript migration so we no longer need Flow related stuff kicking around.

Issue: None

## Test plan:
- yarn test
- cd packages/eslint-plugin-khan
- yarn test

Author: kevinbarabash

Reviewers: jeresig, somewhatabstract

Required Reviewers:

Approved By: jeresig, somewhatabstract

Checks: ✅ codecov/project, ✅ Test (macos-latest, 20.x), ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ⏭️  dependabot, ✅ Analyze (javascript)

Pull Request URL: #1001

Author: kevinbarabash

.changeset/calm-boxes-exist.md

@@ -0,0 +1,5 @@
+---
+"@khanacademy/eslint-plugin": major
+---
+
+Remove Flow related rules

.changeset/light-apes-matter.md

@@ -0,0 +1,8 @@
+---
+"@khanacademy/wonder-stuff-render-environment-jsdom": patch
+"@khanacademy/wonder-stuff-render-server": patch
+"@khanacademy/wonder-stuff-server": patch
+"@khanacademy/wonder-stuff-core": patch
+---
+
+Update comments to no longer reference Flow

.codecov.yml

@@ -5,7 +5,7 @@ coverage:
 
   status:
     project:
-      default: on
+      default: true
     patch:
       default: off
     changes:
@@ -14,14 +14,13 @@ coverage:
 comment:
   layout: "header, reach, diff, flags, files, footer"
   behavior: default
-  require_changes: no
-  require_base: no
-  require_head: yes
+  require_changes: false
+  require_base: false
+  require_head: true
 
 ignore:
   - "build-settings/*.js"
   - "utils/*.js"
   - "packages/**/dist/index.js"
   - "packages/**/types/**/*.ts"
   - "packages/**/examples/**/*.ts"
-  - "packages/**/*.flowtest.js"

CONTRIBUTING.md

@@ -44,11 +44,11 @@ We love code reviews. If there are open pull requests, please feel free to revie
 
 #### Automated
 
-To ensure code quality, we use prettier, flow, eslint, and jest. These are all executed automatically on commit, so don't worry if you forget to run them before you commit. They are also executed when you submit, edit, or push to a pull request to ensure the contribution meets our code quality standard.
+To ensure code quality, we use prettier, TypeScript, eslint, and jest. These are all executed automatically on commit, so don't worry if you forget to run them before you commit. They are also executed when you submit, edit, or push to a pull request to ensure the contribution meets our code quality standard.
 
 To execute these operations outside of a pull request or commit operation, you can use `yarn`.
 
-- `yarn flow`
+- `yarn typecheck`
 - `yarn lint`
 - `yarn test`
 

packages/eslint-plugin-khan/README.md

@@ -6,11 +6,6 @@ eslint plugin with our set of custom rules for various things
 
 ## Rules
 
-- [khan/flow-array-type-style](docs/flow-array-type-style.md)
-- [khan/flow-exact-props](docs/flow-exact-props.md)
-- [khan/flow-exact-state](docs/flow-exact-state.md)
-- [khan/flow-no-one-tuple](docs/flow-no-one-tuple.md)
-- [khan/imports-requiring-flow](docs/imports-requiring-flow.md)
 - [khan/jest-async-use-real-timers](docs/jest-async-use-real-timers.md)
 - [khan/jest-enzyme-matchers](docs/jest-enzyme-matchers.md)
 - [khan/react-no-method-jsx-attribute](docs/react-no-method-jsx-attribute.md)

packages/eslint-plugin-khan/babel.config.js

@@ -2,7 +2,6 @@
 // NOTE(kevinb): This should only be used by eslint-plugin-khan
 module.exports = {
     presets: [
-        "@babel/preset-flow",
         [
             "@babel/preset-env",
             {

packages/eslint-plugin-khan/docs/flow-array-type-style.md

@@ -20,7 +20,6 @@
   "devDependencies": {
     "@babel/eslint-parser": "^7.22.15",
     "@babel/preset-env": "^7.23.2",
-    "@babel/preset-flow": "^7.22.15",
     "@babel/preset-react": "^7.22.15",
     "@swc-node/register": "^1.6.8",
     "@swc/core": "^1.3.93",

packages/eslint-plugin-khan/docs/flow-exact-props.md

@@ -7,12 +7,6 @@ import reactNoSubscriptionsBeforeMount from "./react-no-subscriptions-before-mou
 import reactSvgPathPrecision from "./react-svg-path-precision";
 import syncTag from "./sync-tag";
 import tsNoErrorSupressions from "./ts-no-error-suppressions";
-
-import flowArrayTypeStyle from "./flow-array-type-style";
-import flowExactProps from "./flow-exact-props";
-import flowExactState from "./flow-exact-state";
-import flowNoOneTuple from "./flow-no-one-tuple";
-import importsRequiringFlow from "./imports-requiring-flow";
 import jestEnzymeMatchers from "./jest-enzyme-matchers";
 
 export default {
@@ -25,11 +19,5 @@ export default {
     "react-no-subscriptions-before-mount": reactNoSubscriptionsBeforeMount,
     "react-svg-path-precision": reactSvgPathPrecision,
     "sync-tag": syncTag,
-
-    "flow-array-type-style": flowArrayTypeStyle,
-    "flow-exact-props": flowExactProps,
-    "flow-exact-state": flowExactState,
-    "flow-no-one-tuple": flowNoOneTuple,
-    "imports-requiring-flow": importsRequiringFlow,
     "jest-enzyme-matchers": jestEnzymeMatchers,
 };

packages/eslint-plugin-khan/docs/flow-exact-state.md

@@ -1,4 +1,3 @@
-// @flow
 import {entries} from "../entries";
 
 describe("#entries", () => {

packages/eslint-plugin-khan/docs/flow-no-one-tuple.md

@@ -52,12 +52,6 @@ describe("#makeRenderHandler", () => {
             const handler = makeRenderHandler(fakeRenderEnvironment);
 
             // Act
-            /**
-             * $FlowIgnore[incompatible-call] Middleware<Request, Response>
-             * can mean two different call signatures, and sadly, they both
-             * have completely different argument type ordering, which
-             * totally confused flow here.
-             */
             await handler(fakeRequest, fakeResponse, nextFn);
 
             // Assert
@@ -92,12 +86,6 @@ describe("#makeRenderHandler", () => {
             const handler = makeRenderHandler(fakeRenderEnvironment);
 
             // Act
-            /**
-             * $FlowIgnore[incompatible-call] Middleware<Request, Response>
-             * can mean two different call signatures, and sadly, they both
-             * have completely different argument type ordering, which
-             * totally confused flow here.
-             */
             const underTest = handler(fakeRequest, fakeResponse, nextFn);
 
             // Assert
@@ -136,12 +124,6 @@ describe("#makeRenderHandler", () => {
             const handler = makeRenderHandler(fakeRenderEnvironment);
 
             // Act
-            /**
-             * $FlowIgnore[incompatible-call] Middleware<Request, Response>
-             * can mean two different call signatures, and sadly, they both
-             * have completely different argument type ordering, which
-             * totally confused flow here.
-             */
             const underTest = handler(fakeRequest, fakeResponse, nextFn);
 
             // Assert
@@ -185,12 +167,6 @@ describe("#makeRenderHandler", () => {
             const handler = makeRenderHandler(fakeRenderEnvironment);
 
             // Act
-            /**
-             * $FlowIgnore[incompatible-call] Middleware<Request, Response>
-             * can mean two different call signatures, and sadly, they both
-             * have completely different argument type ordering, which
-             * totally confused flow here.
-             */
             await handler(fakeRequest, fakeResponse, nextFn);
 
             // Assert
@@ -238,14 +214,6 @@ describe("#makeRenderHandler", () => {
                             addLabel: jest.fn(),
                         } as any);
                     const handler = makeRenderHandler(fakeRenderEnvironment);
-                    /**
-                     * $FlowIgnore[incompatible-call]
-                     *
-                     * Middleware<Request, Response> can mean two different
-                     * call signatures, and sadly, they both have completely
-                     * different argument type ordering, which totally confused
-                     * flow here.
-                     */
                     await handler(fakeRequest, fakeResponse, nextFn);
                     const underTest =
                         fakeRenderEnvironment.render.mock.calls[0][1].trace;
@@ -297,12 +265,7 @@ describe("#makeRenderHandler", () => {
                 const handler = makeRenderHandler(fakeRenderEnvironment);
 
                 // Act
-                /**
-                 * $FlowIgnore[incompatible-call] Middleware<Request, Response>
-                 * can mean two different call signatures, and sadly, they both
-                 * have completely different argument type ordering, which
-                 * totally confused flow here.
-                 */
+
                 await handler(fakeRequest, fakeResponse, nextFn);
 
                 // Assert
@@ -362,13 +325,6 @@ describe("#makeRenderHandler", () => {
                     );
 
                     // Act
-                    /**
-                     * $FlowIgnore[incompatible-call]
-                     * Middleware<Request, Response> can mean two different
-                     * call signatures, and sadly, they both have completely
-                     * different argument type ordering, which totally confused
-                     * flow here.
-                     */
                     await handler(fakeRequest, fakeResponse, nextFn);
 
                     // Assert
@@ -417,12 +373,7 @@ describe("#makeRenderHandler", () => {
                 const handler = makeRenderHandler(fakeRenderEnvironment);
 
                 // Act
-                /**
-                 * $FlowIgnore[incompatible-call] Middleware<Request, Response>
-                 * can mean two different call signatures, and sadly, they both
-                 * have completely different argument type ordering, which
-                 * totally confused flow here.
-                 */
+
                 await handler(fakeRequest, fakeResponse, nextFn);
 
                 // Assert
@@ -459,12 +410,7 @@ describe("#makeRenderHandler", () => {
                 const handler = makeRenderHandler(fakeRenderEnvironment);
 
                 // Act
-                /**
-                 * $FlowIgnore[incompatible-call] Middleware<Request, Response>
-                 * can mean two different call signatures, and sadly, they both
-                 * have completely different argument type ordering, which
-                 * totally confused flow here.
-                 */
+
                 await handler(fakeRequest, fakeResponse, nextFn);
 
                 // Assert
@@ -501,12 +447,7 @@ describe("#makeRenderHandler", () => {
                 const handler = makeRenderHandler(fakeRenderEnvironment);
 
                 // Act
-                /**
-                 * $FlowIgnore[incompatible-call] Middleware<Request, Response>
-                 * can mean two different call signatures, and sadly, they both
-                 * have completely different argument type ordering, which
-                 * totally confused flow here.
-                 */
+
                 await handler(fakeRequest, fakeResponse, nextFn);
 
                 // Assert
@@ -550,12 +491,7 @@ describe("#makeRenderHandler", () => {
                 const handleErrorSpy = jest.spyOn(HandleError, "handleError");
 
                 // Act
-                /**
-                 * $FlowIgnore[incompatible-call] Middleware<Request, Response>
-                 * can mean two different call signatures, and sadly, they both
-                 * have completely different argument type ordering, which
-                 * totally confused flow here.
-                 */
+
                 await handler(fakeRequest, fakeResponse, nextFn);
 
                 // Assert
@@ -603,12 +539,7 @@ describe("#makeRenderHandler", () => {
                 );
 
                 // Act
-                /**
-                 * $FlowIgnore[incompatible-call] Middleware<Request, Response>
-                 * can mean two different call signatures, and sadly, they both
-                 * have completely different argument type ordering, which
-                 * totally confused flow here.
-                 */
+
                 await handler(fakeRequest, fakeResponse, nextFn);
 
                 // Assert

packages/eslint-plugin-khan/docs/imports-requiring-flow.md

@@ -42,7 +42,7 @@ export const handleError = async (
 
     /**
      * The calling code should handle if the original request was valid or
-     * not, so we just appease flow here.
+     * not, so we just appease TypeScript here.
      */
     const requestURL = typeof req.query.url === "string" ? req.query.url : "";
 

packages/eslint-plugin-khan/package.json

@@ -1,4 +1,3 @@
-// @flow
 import type {RequestHandler, NextFunction} from "express";
 import {KindError, Errors} from "@khanacademy/wonder-stuff-core";
 import {trace, getLogger} from "@khanacademy/wonder-stuff-server";

packages/eslint-plugin-khan/src/rules/flow-array-type-style.js

@@ -1,4 +1,3 @@
-// @flow
 import {secret} from "@khanacademy/wonder-stuff-core";
 import * as GetRuntimeMode from "../../get-runtime-mode";
 import * as GetLogger from "../../get-logger";

packages/eslint-plugin-khan/src/rules/flow-exact-props.js

@@ -100,10 +100,6 @@ export const traceImpl = (
 
         /**
          * Add some session information to the span as labels.
-         *
-         * Flow doesn't trust the inexact objects returned by memoryUsage()
-         * and so `getDelta` isn't typed to handle that. Have to rethink
-         * how to make that work.
          */
         // @ts-expect-error [FEI-5011] - TS2345 - Argument of type 'MemoryUsage' is not assignable to parameter of type 'NumberObj'.
         addLabel("/memory/delta", getDelta(beforeMemory, afterMemory));

packages/eslint-plugin-khan/src/rules/flow-exact-state.js

@@ -62,7 +62,7 @@ export const trace: ITrace = (
         Object.prototype.hasOwnProperty.call(requestOrLogger, "url")
     ) {
         // We have done a little check to make sure this is either null
-        // or a request, so just tell Flow it's OK.
+        // or a request, so just tell TypeScript it's OK.
         const logger = getLogger(requestOrLogger);
         return traceImpl(logger, action, message, tracer);
     }

packages/eslint-plugin-khan/src/rules/flow-no-one-tuple.js

@@ -408,13 +408,6 @@
   dependencies:
     "@babel/helper-plugin-utils" "^7.8.3"
 
-"@babel/plugin-syntax-flow@^7.22.5":
-  version "7.22.5"
-  resolved "https://registry.yarnpkg.com/@babel/plugin-syntax-flow/-/plugin-syntax-flow-7.22.5.tgz#163b820b9e7696ce134df3ee716d9c0c98035859"
-  integrity sha512-9RdCl0i+q0QExayk2nOS7853w08yLucnnPML6EN9S8fgMPVtdLDCdx/cOQ/i44Lb9UeQX9A35yaqBBOMMZxPxQ==
-  dependencies:
-    "@babel/helper-plugin-utils" "^7.22.5"
-
 "@babel/plugin-syntax-import-assertions@^7.22.5":
   version "7.22.5"
   resolved "https://registry.yarnpkg.com/@babel/plugin-syntax-import-assertions/-/plugin-syntax-import-assertions-7.22.5.tgz#07d252e2aa0bc6125567f742cd58619cb14dce98"
@@ -647,14 +640,6 @@
     "@babel/helper-plugin-utils" "^7.22.5"
     "@babel/plugin-syntax-export-namespace-from" "^7.8.3"
 
-"@babel/plugin-transform-flow-strip-types@^7.22.5":
-  version "7.22.5"
-  resolved "https://registry.yarnpkg.com/@babel/plugin-transform-flow-strip-types/-/plugin-transform-flow-strip-types-7.22.5.tgz#0bb17110c7bf5b35a60754b2f00c58302381dee2"
-  integrity sha512-tujNbZdxdG0/54g/oua8ISToaXTFBf8EnSb5PgQSciIXWOWKX3S4+JR7ZE9ol8FZwf9kxitzkGQ+QWeov/mCiA==
-  dependencies:
-    "@babel/helper-plugin-utils" "^7.22.5"
-    "@babel/plugin-syntax-flow" "^7.22.5"
-
 "@babel/plugin-transform-for-of@^7.22.15":
   version "7.22.15"
   resolved "https://registry.yarnpkg.com/@babel/plugin-transform-for-of/-/plugin-transform-for-of-7.22.15.tgz#f64b4ccc3a4f131a996388fae7680b472b306b29"
@@ -1046,15 +1031,6 @@
     core-js-compat "^3.31.0"
     semver "^6.3.1"
 
-"@babel/preset-flow@^7.22.15":
-  version "7.22.15"
-  resolved "https://registry.yarnpkg.com/@babel/preset-flow/-/preset-flow-7.22.15.tgz#30318deb9b3ebd9f5738e96da03a531e0cd3165d"
-  integrity sha512-dB5aIMqpkgbTfN5vDdTRPzjqtWiZcRESNR88QYnoPR+bmdYoluOzMX9tQerTv0XzSgZYctPfO1oc0N5zdog1ew==
-  dependencies:
-    "@babel/helper-plugin-utils" "^7.22.5"
-    "@babel/helper-validator-option" "^7.22.15"
-    "@babel/plugin-transform-flow-strip-types" "^7.22.5"
-
 "@babel/preset-modules@0.1.6-no-external-plugins":
   version "0.1.6-no-external-plugins"
   resolved "https://registry.yarnpkg.com/@babel/preset-modules/-/preset-modules-0.1.6-no-external-plugins.tgz#ccb88a2c49c817236861fee7826080573b8a923a"