[FIX] Display message instead of error on TAB

Author: KeyWeeUsr

Diff for: syncthing-constants.el

@@ -11,6 +11,8 @@
 (defconst syncthing-day-seconds (* 1 60 60 24))
 (defconst syncthing-hour-seconds (* 1 60 60))
 (defconst syncthing-min-seconds (* 1 60))
+(defconst syncthing-msg-cant-edit-buffer
+  "You can not edit this part of the Syncthing buffer")
 
 ;; Docstrings from Syncthing (MPL-2.0)
 ;; https://www.fsf.org/blogs/licensing/mpl-2.0-release

Diff for: syncthing-errors.el

@@ -7,10 +7,6 @@
 
 (define-error 'syncthing-error "Generic syncthing error")
 
-(define-error 'syncthing-error-cant-edit-buffer
-  "You can not edit this part of the Syncthing buffer"
-  'syncthing-error)
-
 (define-error 'syncthing-error-cant-authenticate
   "Failed to authenticate, check the token!"
   'syncthing-error)

Diff for: syncthing-keyboard-tests.el

@@ -9,6 +9,7 @@
 (require 'widget)
 
 (require 'syncthing-common)
+(require 'syncthing-constants)
 (require 'syncthing-errors)
 (require 'syncthing-keyboard)
 
@@ -34,14 +35,15 @@
   "Throw an error when interacting with a non-widget."
   (syncthing-ert-cleanup)
   (with-temp-buffer
-    (let (called)
-      (condition-case err
-          (syncthing--newline 1)  ; Move into the button area first
-        (syncthing-error
-         (setq called t)
-         (should (string= (error-message-string err)
-                          (get 'syncthing-error-cant-edit-buffer
-                               'error-message)))))
+    (let (called args)
+      (advice-add 'message
+                  :override
+                  (lambda (&rest largs) (setq called t) (setq args largs)))
+      (syncthing--newline 1)  ; Move into the button area first
+      (advice-remove 'message
+                     (lambda (&rest largs) (setq called t) (setq args largs)))
+      (should called)
+      (should (string= (caddr args) syncthing-msg-cant-edit-buffer))
       (should called))))
 
 (ert-deftest syncthing-keyboard-tab-fold-all ()

Diff for: syncthing-keyboard.el

@@ -9,6 +9,7 @@
 (require 'wid-edit)
 
 (require 'syncthing-common)
+(require 'syncthing-constants)
 (require 'syncthing-draw)
 (require 'syncthing-errors)
 (require 'syncthing-state)
@@ -39,7 +40,7 @@ Argument POS Incoming EVENT position."
   (let ((button (syncthing--get-widget pos)))
     (if button
 	    (widget-apply-action button event)
-      (signal 'syncthing-error-cant-edit-buffer nil))))
+      (message "%s: %s" syncthing-prefix syncthing-msg-cant-edit-buffer))))
 
 (defun syncthing--tab (&rest _)
   "TAB handler.