Skip to content

Commit 9ea3daa

Browse files
authored
refactor (NuGettier.Upm): add more detailed trace-logs (refactor/expand-trace-logs) [#227]
- **refactor (NuGettier.Upm): add more trace-logs to Upm.Context.FetchPackage()** - **refactor (NuGettier.Upm): log when package could not be found for a given resource in Upm.Context.FetchPackage()** - **refactor (NuGettier.Upm): add more trace-logs to Upm.Context.GetPackageInformation()**
1 parent e047458 commit 9ea3daa

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

NuGettier.Core/Context/FetchPackage.cs

+9
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,15 @@ CancellationToken cancellationToken
2828
)
2929
{
3030
using var scope = Logger.TraceLocation().BeginScope(this.__METHOD__());
31+
Logger.LogTrace("fetching {0} (prerelease: {1})", packageIdVersion, preRelease);
3132
using var nugetLogger = NuGetLogger.Create(LoggerFactory);
3233

3334
packageIdVersion.SplitPackageIdVersion(out var packageId, out var version, out var latest);
3435
IEnumerable<FindPackageByIdResource> resources = await Repositories.GetResourceAsync<FindPackageByIdResource>(
3536
cancellationToken
3637
);
38+
Logger.LogTrace("trying to get '{0}' version {1} (latest: {2})", packageId, version, latest);
39+
3740
IEnumerable<NuGetVersion> versions = (
3841
await resources.GetAllVersionsAsync(packageId, Cache, nugetLogger, cancellationToken)
3942
).Distinct();
@@ -43,11 +46,13 @@ await resources.GetAllVersionsAsync(packageId, Cache, nugetLogger, cancellationT
4346
{
4447
Logger.LogTrace("fetching latest version for {0}", packageId);
4548
packageVersion = versions.Last();
49+
Logger.LogTrace("latest version is {0}", packageVersion);
4650
}
4751
else if (version != null)
4852
{
4953
Logger.LogTrace("fetching version {1} for {0}", packageId, version);
5054
packageVersion = new NuGetVersion(version);
55+
Logger.LogTrace("required version is {0}", packageVersion);
5156
}
5257
Logger.LogDebug("fetching {0}@{1}", packageId, packageVersion);
5358

@@ -85,6 +90,10 @@ await resource.CopyNupkgToStreamAsync(
8590

8691
return packageStream;
8792
}
93+
else
94+
{
95+
Logger.LogDebug("package {0}@{1} does not exist on {2}", packageId, packageVersion, resource);
96+
}
8897
}
8998
}
9099

NuGettier.Upm/Context/GetPackageInformation.cs

+2
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ CancellationToken cancellationToken
2929
)
3030
{
3131
using var scope = Logger.TraceLocation().BeginScope(this.__METHOD__());
32+
Logger.LogTrace("getting package information for {0} (prerelease: {1})", packageIdVersion, preRelease);
33+
3234
packageIdVersion.SplitPackageIdVersion(out var packageId, out var version, out var latest);
3335
var packageSearchMetadata = await base.GetPackageInformation(
3436
packageIdVersion: packageIdVersion,

0 commit comments

Comments
 (0)