Skip to content
This repository was archived by the owner on Sep 24, 2023. It is now read-only.

1.12 makes KDAB internals mandatory #334

Open
adriaandegroot opened this issue Sep 1, 2018 · 2 comments
Open

1.12 makes KDAB internals mandatory #334

adriaandegroot opened this issue Sep 1, 2018 · 2 comments

Comments

@adriaandegroot
Copy link

In 1.11, it was possible to build without QtKeyChain, and then all the KDAB internals -- your in-jokes about lotsofcake, Bill, as well as the dependency on QtKeyChain and all the HTTP and REST-API support code -- would be left out. In 1.12 this dependency is required (in CMake) and all the support for optional cake has been removed; none of it is visible to the user without the undocumented KDAB-internal configuration settings, but it's weirdly annoying to pull in such unused dependencies.

@frankosterfeld
Copy link
Member

These features (i.e. timesheet reminder etc.) should only be enabled on the UI level once someone imported project codes from KDAB's server, need to investigate why they are suddenly enabled for everyone.

@adriaandegroot
Copy link
Author

Sorry, I should have phrased that better:

  • the features are not enabled at the UI level
  • the supporting code is enabled, which is kind of annoying because of the extra dependencies
    The previous version left out all the supporting code (and the UI) when qtkeychain wasn't found.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants