lazily load feature packages (#113)

* lazily load feature packages

* require LazyModules v0.3.0

* world-age-issue: skip reference file if not existed

Author: johnnychen94

Project.toml

@@ -4,17 +4,20 @@ authors = ["Christof Stocker <[email protected]>", "Lyndon White <oxina
 version = "0.9.11"
 
 [deps]
+Colors = "5ae59095-9a9b-59fe-a467-6f913c188581"
 DeepDiffs = "ab62b9b5-e342-54a8-a765-a90f495de1a6"
 Distances = "b4f34e82-e78d-54a5-968a-f98e89d6e8f7"
 FileIO = "5789e2e9-d7fb-5bc7-8068-2c6fae9b9549"
 ImageCore = "a09fc81d-aa75-5fe9-8630-4744c3626534"
 ImageInTerminal = "d8c32880-2388-543b-8c61-d9f865259254"
+LazyModules = "8cdb02fc-e678-4876-92c5-9defec4f444e"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 SHA = "ea8e919c-243c-51af-8825-aaa63cd721ce"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [compat]
 BSON = "0.3"
+Colors = "0.10, 0.11, 0.12"
 CSVFiles = "1"
 DataFrames = "0.21, 0.22"
 DeepDiffs = "1.1"
@@ -25,6 +28,7 @@ ImageCore = "0.8.1, 0.9"
 ImageInTerminal = "0.3, 0.4"
 ImageMagick = "0.7, 1"
 ImageTransformations = "0.8"
+LazyModules = "0.3"
 Plots = "= 1.4.3"
 TestImages = "0.6, 1"
 julia = "1"

src/ReferenceTests.jl

@@ -1,10 +1,13 @@
 module ReferenceTests
 
+using LazyModules
+
 using Test
-using ImageCore
+using Colors
 using Distances
 using FileIO
-using ImageInTerminal
+@lazy import ImageCore = "a09fc81d-aa75-5fe9-8630-4744c3626534"
+@lazy import ImageInTerminal = "d8c32880-2388-543b-8c61-d9f865259254"
 using SHA
 using DeepDiffs
 using Random

src/equality_metrics.jl

@@ -52,13 +52,13 @@ end
 
 # a simplified PSNR is sufficient since we only use it to approximately compare two images
 _psnr(ref::AbstractArray{<:Color3}, x::AbstractArray{<:Color3}) =
-    _psnr(channelview(RGB.(ref)), channelview(RGB.(x)), 1.0)
+    _psnr(ImageCore.channelview(RGB.(ref)), ImageCore.channelview(RGB.(x)), 1.0)
 
 _psnr(ref::AbstractArray{<:ColorTypes.Transparent3}, x::AbstractArray{<:ColorTypes.Transparent3}) =
-    _psnr(channelview(ARGB.(ref)), channelview(ARGB.(x)), 1.0)
+    _psnr(ImageCore.channelview(ARGB.(ref)), ImageCore.channelview(ARGB.(x)), 1.0)
 
 _psnr(ref::AbstractArray{<:AbstractGray}, x::AbstractArray{<:AbstractGray}) =
-    _psnr(channelview(ref), channelview(x), 1.0)
+    _psnr(ImageCore.channelview(ref), ImageCore.channelview(x), 1.0)
 
 _psnr(ref::AbstractArray{<:Real}, x::AbstractArray{<:Real}, peakval::Real) =
     20log10(peakval) - 10log10(_mse(float.(ref), float.(x)))

src/fileio.jl

@@ -79,7 +79,8 @@ _convert(::Type{DataFormat{:SHA256}}, x; kw...) = bytes2hex(sha256(string(x)))
 function _convert(::Type{DataFormat{:SHA256}}, img::AbstractArray{<:Colorant}; kw...)
     # encode image into SHA256
     size_str = bytes2hex(sha256(reinterpret(UInt8,[map(Int64,size(img))...])))
-    img_str = bytes2hex(sha256(reinterpret(UInt8,vec(rawview(channelview(img))))))
+    img_bytes = vec(ImageCore.rawview(ImageCore.channelview(img)))
+    img_str = bytes2hex(sha256(reinterpret(UInt8, img_bytes)))
 
     return size_str * img_str
 end

test/runtests.jl

@@ -1,9 +1,8 @@
 using Test
-using ImageInTerminal, TestImages, ImageCore, ImageTransformations
-using BSON:BSON
 using FileIO
-using Plots
+using BSON: BSON
 using Random
+using ReferenceTests
 
 if isinteractive()
     @info ("In interactive use, one should respond \"n\" when the program"
@@ -12,18 +11,21 @@ else
     @info ("Ten tests should correctly report failure in the transcript"
            * " (but not the test summary).")
 end
-# check for ambiguities
-refambs = detect_ambiguities(ImageInTerminal, Base, Core)
 
-using ReferenceTests
-ambs = detect_ambiguities(ReferenceTests, ImageInTerminal, Base, Core)
+
+ambs = detect_ambiguities(ReferenceTests, Base, Core)
+@test isempty(ambs)
+
+# to properly test world age issues, the full test dependencies must be loaded later
+include("test_no_world_age_issues.jl")
+
+using ImageInTerminal, TestImages, ImageCore, ImageTransformations
+using Plots
 
 strip_summary(content::String) = join(split(content, "\n")[2:end], "\n")
 
 @testset "ReferenceTests" begin
 
-@test Set(setdiff(ambs, refambs)) == Set{Tuple{Method,Method}}()
-
 # load/create some example images
 lena = testimage("lena_color_256")
 camera = testimage("cameraman")

test/test_no_world_age_issues.jl

@@ -0,0 +1,12 @@
+@testset "world age issues" begin
+    files = ["references/camera.png"]
+
+    for filename in files
+        ref_file = joinpath(@__DIR__, filename)
+        if isfile(ref_file)
+            @test_reference filename load(ref_file)
+        else
+            @info "Skip reference file: $ref_file"
+        end
+    end
+end