Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests for Git + filesystem + Docker #51

Closed
christopher-dG opened this issue Feb 5, 2020 · 1 comment
Closed

Integration tests for Git + filesystem + Docker #51

christopher-dG opened this issue Feb 5, 2020 · 1 comment

Comments

@christopher-dG
Copy link
Member

Right now pretty much everything GitHub/Git/FS/-related is mocked out during tests. I'm not really interested in doing VCR testing for the GitHub API, but I would definitely like to run some tests that make sure that our Git commands and other filesystem manipulations are actually doing the things we want them to.
Also, I want to be able to run the tests in a freshly built Docker image too.
@christopher-dG christopher-dG mentioned this issue Feb 5, 2020
Merged
christopher-dG added a commit that referenced this issue Mar 8, 2020
@christopher-dG
Fix tagging with SSH key
34662b2 
This is why #51 is really important.
@christopher-dG christopher-dG mentioned this issue Apr 1, 2021
Closed
@christopher-dG
Copy link
Member Author

I'm closing this now because I'm never going to get around to writing these tests, and the testing strategy for #55 will be totally different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@christopher-dG