Skip to content

Commit dddc219

Browse files
authored
[AutoBuild] Filter out non-build deps before calling setup_dependencies (#1209)
1 parent 06621c4 commit dddc219

File tree

5 files changed

+32
-30
lines changed

5 files changed

+32
-30
lines changed

Manifest.toml

+20-20
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This file is machine-generated - editing it directly is not advised
22

3-
julia_version = "1.7.2"
3+
julia_version = "1.7.3"
44
manifest_format = "2.0"
55

66
[[deps.ArgParse]]
@@ -31,11 +31,11 @@ uuid = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
3131

3232
[[deps.BinaryBuilderBase]]
3333
deps = ["CodecZlib", "Downloads", "InteractiveUtils", "JSON", "LibGit2", "LibGit2_jll", "Libdl", "Logging", "OrderedCollections", "OutputCollectors", "Pkg", "ProgressMeter", "Random", "SHA", "Scratch", "SimpleBufferStream", "TOML", "Tar", "UUIDs", "p7zip_jll", "pigz_jll"]
34-
git-tree-sha1 = "515d28b82ab1a721b31ddb6a11f8fa5662fc9e91"
34+
git-tree-sha1 = "c85100c358dbcd7d918130ab333bf57c7f375f68"
3535
repo-rev = "master"
3636
repo-url = "https://github.com/JuliaPackaging/BinaryBuilderBase.jl.git"
3737
uuid = "7f725544-6523-48cd-82d1-3fa08ff4056e"
38-
version = "1.10.1"
38+
version = "1.12.0"
3939

4040
[[deps.CodecZlib]]
4141
deps = ["TranscodingStreams", "Zlib_jll"]
@@ -45,18 +45,18 @@ version = "0.7.0"
4545

4646
[[deps.Compat]]
4747
deps = ["Base64", "Dates", "DelimitedFiles", "Distributed", "InteractiveUtils", "LibGit2", "Libdl", "LinearAlgebra", "Markdown", "Mmap", "Pkg", "Printf", "REPL", "Random", "SHA", "Serialization", "SharedArrays", "Sockets", "SparseArrays", "Statistics", "Test", "UUIDs", "Unicode"]
48-
git-tree-sha1 = "b153278a25dd42c65abbf4e62344f9d22e59191b"
48+
git-tree-sha1 = "9be8be1d8a6f44b96482c8af52238ea7987da3e3"
4949
uuid = "34da2185-b29b-5c13-b0c7-acf172513d20"
50-
version = "3.43.0"
50+
version = "3.45.0"
5151

5252
[[deps.CompilerSupportLibraries_jll]]
5353
deps = ["Artifacts", "Libdl"]
5454
uuid = "e66e0078-7015-5450-92f7-15fbd957f2ae"
5555

5656
[[deps.DataAPI]]
57-
git-tree-sha1 = "cc70b17275652eb47bc9e5f81635981f13cea5c8"
57+
git-tree-sha1 = "fb5f5316dd3fd4c5e7c30a24d50643b73e37cd40"
5858
uuid = "9a962f9c-6df0-11e9-0e5d-c546b8b5ee8a"
59-
version = "1.9.0"
59+
version = "1.10.0"
6060

6161
[[deps.DataValueInterfaces]]
6262
git-tree-sha1 = "bfc1187b79289637fa0ef6d4436ebdfe6905cbd6"
@@ -76,7 +76,7 @@ deps = ["Random", "Serialization", "Sockets"]
7676
uuid = "8ba89e20-285c-5b6f-9357-94700520ee1b"
7777

7878
[[deps.Downloads]]
79-
deps = ["ArgTools", "LibCURL", "NetworkOptions"]
79+
deps = ["ArgTools", "FileWatching", "LibCURL", "NetworkOptions"]
8080
uuid = "f43a241f-c20a-4ad4-852c-f6b1247861c6"
8181

8282
[[deps.ExprTools]]
@@ -86,9 +86,9 @@ version = "0.1.8"
8686

8787
[[deps.FileIO]]
8888
deps = ["Pkg", "Requires", "UUIDs"]
89-
git-tree-sha1 = "80ced645013a5dbdc52cf70329399c35ce007fae"
89+
git-tree-sha1 = "9267e5f50b0e12fdfd5a2455534345c4cf2c7f7a"
9090
uuid = "5789e2e9-d7fb-5bc7-8068-2c6fae9b9549"
91-
version = "1.13.0"
91+
version = "1.14.0"
9292

9393
[[deps.FileWatching]]
9494
uuid = "7b1f6079-737a-58dc-b8bc-7a2ca5c1b5ee"
@@ -187,9 +187,9 @@ uuid = "56ddb016-857b-54e1-b83d-db4d58db5568"
187187

188188
[[deps.LoggingExtras]]
189189
deps = ["Dates", "Logging"]
190-
git-tree-sha1 = "dfeda1c1130990428720de0024d4516b1902ce98"
190+
git-tree-sha1 = "5d4d2d9904227b8bd66386c1138cf4d5ffa826bf"
191191
uuid = "e6f89c97-d47a-5376-807f-9c37f3926c36"
192-
version = "0.4.7"
192+
version = "0.4.9"
193193

194194
[[deps.MacroTools]]
195195
deps = ["Markdown", "Random"]
@@ -260,9 +260,9 @@ version = "0.1.1"
260260

261261
[[deps.Parsers]]
262262
deps = ["Dates"]
263-
git-tree-sha1 = "621f4f3b4977325b9128d5fae7a8b4829a0c2222"
263+
git-tree-sha1 = "1285416549ccfcdf0c50d4997a94331e88d68413"
264264
uuid = "69de0a69-1ddd-5017-9359-2bf0b02dc9f0"
265-
version = "2.2.4"
265+
version = "2.3.1"
266266

267267
[[deps.Pidfile]]
268268
deps = ["FileWatching", "Test"]
@@ -282,9 +282,9 @@ version = "0.2.0"
282282

283283
[[deps.Preferences]]
284284
deps = ["TOML"]
285-
git-tree-sha1 = "d3538e7f8a790dc8903519090857ef8e1283eecd"
285+
git-tree-sha1 = "47e5f437cc0e7ef2ce8406ce1e7e24d44915f88d"
286286
uuid = "21216c6a-2e73-6563-6e65-726566657250"
287-
version = "1.2.5"
287+
version = "1.3.0"
288288

289289
[[deps.Printf]]
290290
deps = ["Unicode"]
@@ -311,15 +311,15 @@ version = "1.2.2"
311311

312312
[[deps.Registrator]]
313313
deps = ["AutoHashEquals", "Base64", "Dates", "Distributed", "FileWatching", "GitForge", "GitHub", "HTTP", "JSON", "LibGit2", "Logging", "MbedTLS", "Mocking", "Mustache", "Mux", "Pkg", "RegistryTools", "Serialization", "Sockets", "TimeToLive", "UUIDs", "ZMQ"]
314-
git-tree-sha1 = "8e1a5ac2695627143951512d700c7e3c445102ec"
314+
git-tree-sha1 = "419649a25cd38e1baab69ad2948870799964a5a3"
315315
uuid = "4418983a-e44d-11e8-3aec-9789530b3b3e"
316-
version = "1.2.9"
316+
version = "1.4.0"
317317

318318
[[deps.RegistryTools]]
319319
deps = ["AutoHashEquals", "LibGit2", "Pkg", "SHA", "UUIDs"]
320-
git-tree-sha1 = "7ba3c65d4f40a399e5a2f0ec5abc89de871604e5"
320+
git-tree-sha1 = "aceb02a844394332608c88d7da6217daf2b5e4e5"
321321
uuid = "d1eb7eb1-105f-429d-abf5-b0f65cb9e2c4"
322-
version = "1.7.0"
322+
version = "1.8.1"
323323

324324
[[deps.Requires]]
325325
deps = ["UUIDs"]

Project.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "BinaryBuilder"
22
uuid = "12aac903-9f7c-5d81-afc2-d9565ea332ae"
33
authors = ["Elliot Saba <[email protected]>"]
4-
version = "0.5.4"
4+
version = "0.5.5"
55

66
[deps]
77
ArgParse = "c7e460c6-2fb9-53a9-8c5b-16f535851c63"
@@ -33,7 +33,7 @@ ghr_jll = "07c12ed4-43bc-5495-8a2a-d5838ef8d533"
3333

3434
[compat]
3535
ArgParse = "1.1"
36-
BinaryBuilderBase = "1.10"
36+
BinaryBuilderBase = "1.12"
3737
GitHub = "5.1"
3838
HTTP = "0.8, 0.9"
3939
JLD2 = "0.1.6, 0.2, 0.3, 0.4"

docs/src/building.md

+8-6
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,8 @@ dependencies = [
330330

331331
* [`Dependency`](@ref) specify a JLL package that is necessary to build and load
332332
the current builder. Binaries for the target platform will be installed;
333+
* [`RuntimeDependency`](@ref): a JLL package that is necessary only at runtime. Its
334+
artifact will not be installed in the prefix during the build.
333335
* [`BuildDependency`](@ref) is a JLL package necessary only to build the current
334336
package, but not to load it. This dependency will install binaries for the
335337
target platforms and will not be added to the list of the dependencies of the
@@ -338,11 +340,11 @@ dependencies = [
338340
install binaries for the host system. This kind of dependency is usually
339341
added to provide some binary utilities to run during the build process.
340342

341-
The argument of `Dependency`, `BuildDependency`, and `HostBuildDependency` can
342-
also be a `Pkg.PackageSpec`, with which you can specify more details about the
343-
dependency, like a version number, or also a non-registered package. Note that
344-
in Yggdrasil only JLL packages in the [General
345-
registry](https://github.com/JuliaRegistries/General) can be accepted.
343+
The argument of `Dependency`, `RuntimeDependency`, `BuildDependency`, and
344+
`HostBuildDependency` can also be a `Pkg.PackageSpec`, with which you can
345+
specify more details about the dependency, like a version number, or also a
346+
non-registered package. Note that in Yggdrasil only JLL packages in the
347+
[General registry](https://github.com/JuliaRegistries/General) can be accepted.
346348

347349
The dependencies for the target system (`Dependency` and `BuildDependency`) will
348350
be installed under `${prefix}` within the build environment, while the
@@ -358,7 +360,7 @@ Examples of builders that depend on other binaries include:
358360
depends on `Xorg_libxcb_jll`, and `Xorg_xtrans_jll` at build- and run-time,
359361
and on `Xorg_xorgproto_jll` and `Xorg_util_macros_jll` only at build-time.
360362

361-
### Platform-dependent dependencies
363+
### Platform-specific dependencies
362364

363365
By default, all dependencies are used for all platforms, but there are some
364366
cases where a package requires some dependencies only on some platforms. You

src/AutoBuild.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,7 @@ function autobuild(dir::AbstractString,
785785
verbose=verbose,
786786
)
787787
setup_deps(f, prefix, dependencies, platform, verbose) =
788-
setup_dependencies(prefix, Pkg.Types.PackageSpec[getpkg(d) for d in filter_platforms(dependencies, platform) if f(d)], platform; verbose)
788+
setup_dependencies(prefix, Pkg.Types.PackageSpec[getpkg(d) for d in filter_platforms(dependencies, platform) if f(d) && is_build_dependency(d)], platform; verbose)
789789
host_artifact_paths = setup_deps(is_host_dependency, prefix, dependencies, default_host_platform, verbose)
790790
target_artifact_paths = setup_deps(is_target_dependency, prefix, dependencies, concrete_platform, verbose)
791791

src/BinaryBuilder.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export AnyPlatform
2222
export Product, LibraryProduct, FileProduct, ExecutableProduct, FrameworkProduct, satisfied,
2323
locate, write_deps_file, variable_name
2424
# BinaryBuilderBase/src/Dependency.jl
25-
export Dependency, BuildDependency, HostBuildDependency
25+
export Dependency, RuntimeDependency, BuildDependency, HostBuildDependency
2626
# BinaryBuilderBase/src/Sources.jl
2727
export ArchiveSource, FileSource, GitSource, DirectorySource
2828
# Auditor.jl

0 commit comments

Comments
 (0)